this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Skip events with empty since if we've got a valid rev for the repo (#511)

authored by

Jaz and committed by
GitHub
e0ade54c 71e21e5d

+6 -3
+6 -3
backfill/gormstore.go
··· 154 154 return false, fmt.Errorf("invalid job state: %q", j.state) 155 155 } 156 156 157 - if j.rev >= rev { 157 + if j.rev >= rev || (since == nil && j.rev != "") { 158 158 // we've already accounted for this event 159 159 return false, ErrAlreadyProcessed 160 160 } ··· 320 320 } 321 321 322 322 if opset.since == nil { 323 - // TODO: what does this mean? 324 - return fmt.Errorf("nil since in event after backfill: %w", ErrEventGap) 323 + // The first event for a repo may have a nil since 324 + // We should process it only if the rev is empty, skip otherwise 325 + if j.rev != "" { 326 + continue 327 + } 325 328 } 326 329 327 330 if j.rev > *opset.since {