fix: use tokio-native async fs functions #13

Closed

aly.codes 3mo ago

targeting main from lucascherzer.de/appa:fix/async-fs-calls

Closed opened by and assigned to

aly.codes 3mo ago targeting main from lucascherzer.de/appa:fix/async-fs-calls

Calling sync fs functions in an async context could block worker threads.

This change replaces calls of fs:😗 with tokio::fs:😗.

We could automate checks like this in the future using semgrep and (shameless plug) https://tangled.org/lucascherzer.de/semgrep-rules/.

Commits 0

Could not load commits.

Comments

v0 3mo ago

aly.codes 3mo ago

thank you for the PR! I think I'm gonna pass on it for now.

One slightly annoying thing to work around is that tokio::fs isn't really a magic ticket here. Those file system writes are still synchronous, just on another pool, which is theoretically nice but adds a lot of complexity. The directory walk itself is still synchronous, for example, and that's probably more costly.

Since this is a potential correctness issue I'd prefer to keep the code simple and reliable for now. If we can point to some tangible slowdowns in materialization I'd be happy to reconsider a bigger rework!

Versions