pneumo-reviewer: round 1, APPROVE #
PR #13 adds one [tasks."e2e:server"] block to mise.toml that runs the existing @pneumo/server test:e2e script (vitest.e2e.config.ts, globalSetup → startMinio()). That is exactly ENG-249's deferred scope item, and nothing else changed. It sits next to check:server as e2e:android sits next to check:android, and it stays out of check and CI (CI comes in M5).
Findings #
- FILE (often 3 × bad 1 = 3),
README.md:65: the README still names mise exec -- pnpm --filter @pneumo/server test:e2e for the MinIO suite instead of mise run e2e:server. It still works; the doc just drifts. Filed for the next README change.
- FILE (often 2 × bad 2 = 4),
scripts/e2e/minio.ts:106-116 with apps/server/e2e/global-setup.ts: Ctrl-C during an e2e run leaves its pneumo-e2e-* MinIO container running (reproduced three ways). This comes from PR #12, not this PR. Impact is small: 127.0.0.1 only, fake credentials, and the next run removes containers older than 2 h. Filed.
Spec / DoD #
- §4 task list and §17
e2e:server: OK. One uniquely named container on a random 127.0.0.1 port, removed after the run.
- The e2e suite builds its S3 config only from the injected harness values, so a developer's
.env.local can't point it at the dev bucket.
- DoD: MinIO integration coverage through
e2e:server is present; the other items don't apply.
Tests run by the reviewer: mise run e2e:server exit 0 (7 tests, no container left); mise run check:infra exit 0. Pipeline for 0f2df95: 3/3 green.
