comms: notice-enum for unified notify pipeline #661

Open

targeting main from lt/notice-enum

Open opened by and assigned to

oyster.cafe 3w ago targeting main from lt/notice-enum

Such that a Notice must be one of these exact messages, no more no less.

Commits 0

Could not load commits.

Comments

v0 3w ago

This is so clean! Thank you for continuing to refine the notices!

crates/tranquil-pds/src/comms/notice.rs:183 this should be VerificationTarget? MigrationTarget doesn't have the ViaEmail thing with the channel in it.

alternatively, maybe do something like

 pub struct IssuedVerification<'a> {
      target: &'a VerificationTarget,
      purpose: VerificationPurpose,
      code: VerificationCode,
  }

and then implement mint/link/valid_for. And then

  SignupVerification { issued: IssuedVerification<'a> },
  MigrationVerification { issued: IssuedVerification<'a> },

and now that bug can't happen?

crates/tranquil-pds/src/comms/notice.rs:146 feel free to ignore but I think it might be worth splitting this into two kinds of notices, like, AccountNotice and VerificationNotice, depending on whether it uses handle. Then you can eg delete crates/tranquil-pds/src/comms/notice.rs:231 I think?

anyway excellent types

fuck good points, thank you, implementing

v1 1d ago

@jola.dev not sure if you get auto notifs when a PR is updated, so