rs-auth: init #50

Closed

bwc9876.dev 4w ago

targeting main from ben/init-basic-apps

Closed opened by and assigned to

bwc9876.dev 4w ago targeting main from ben/init-basic-apps

Commits 0

Could not load commits.

Comments

bwc9876.dev 1mo ago

pkgs/rs-auth/lib.rs:23

Need to fully qualify with crate:: for stupid useless lint

bwc9876.dev 1mo ago

pkgs/rs-auth/config.rs:51

Might change this to always generate a new one and remove the config option. Since we're probably fine to only make sessions persist for the runtime of the program.

bwc9876.dev 1mo ago

Why did I make a separate mod for errors

bwc9876.dev 1mo ago

pkgs/rs-auth/lib.rs:26

Past me was so naive.... if only he could see what I had to do for LTI

bwc9876.dev 1mo ago

pkgs/rs-auth/lib.rs:99

I should use the router.nest() pattern I started using for LTI and stuff here

bwc9876.dev 1mo ago

pkgs/rs-auth/routes.rs:105

This was mostly just testing out the OIDC crate and making sure I knew how to use it. I will probably clean it up when I implement actual auth and stuff.

huy55465.tngl.sh 1mo ago

pkgs/rs-auth/Cargo.toml:19rs-auth ignoring invalid dependency rs-top because rs-top doesn't have a lib.rs?

huy55465.tngl.sh 1mo ago

pkgs/rs-auth/config.rs:35 Can the value of key_opt change, if jar_key_path never changes? If not, could we store the key inside the struct?

bwc9876.dev 1mo ago

For Nix reasons we don't want the key to be inline in the config file. I was thinking of just making a new key each run anyway tho.

huy55465.tngl.sh 1mo ago

pkgs/rs-auth/lib.rs:88hmm typo of "redirect" or intentional?

huy55465.tngl.sh 1mo ago

Anyways LGTM

demsem.dev 4w ago

LGTM except for "rediret"

v0 4w ago

Versions