The (aspirational) foundation of CS at WCU!

rs-runner: init #55

Closed

bwc9876.dev 4w ago

targeting main from ben/init-basic-apps

Closed opened by and assigned to

bwc9876.dev 4w ago targeting main from ben/init-basic-apps

Commits 0

Could not load commits.

Comments

bwc9876.dev 1mo ago

pkgs/rs-runner/config.rs:19

Actually this shouldn't be a thing anymore, oops.

bwc9876.dev 1mo ago

pkgs/rs-runner/judge.rs:135

Should invert this and do an early return instead prolly

bwc9876.dev 1mo ago

pkgs/rs-runner/routes.rs:11

Need to remove this

bwc9876.dev 1mo ago

pkgs/rs-runner/judge.rs:204

Temp for now, I think I should just use rand for this now that LTI uses it too.

bwc9876.dev 1mo ago

pkgs/rs-runner/run.rs:244

Maybe explain what this line does since it otherwise might not be obvious

huy55465.tngl.sh 4w ago

pkgs/rs-runner/judge.rs:27hmm what are these two numbers?

huy55465.tngl.sh 4w ago

pkgs/rs-runner/judge.rs:15bub(b)lewrap typo?

huy55465.tngl.sh 4w ago

pkgs/rs-runner/routes.rs:11should we add a doc comment saying something like "hey body is a msgpack"?

demsem.dev 4w ago

pkgs/rs-runner/judge.rs:188 Possibly implement/add sorted insertion... 🇳🇱

demsem.dev 4w ago

pkgs/rs-runner/lib.rs:37 Upper is first arg, lower is second arg...

pkgs/rs-runner/lib.rs:46 Lower is first arg, upper is second arg..

Maybe different parameter names would be helpful.

demsem.dev 4w ago

pkgs/rs-runner/run.rs:98

Clear buf here

bwc9876.dev 4w ago

For body, uh we won't use msgpack soon so im not gonna doc it
Sorted insertion will probably be more trouble than it's worth since i have to order by a key
For the silly quota stuff i will fix it in my new changes since otherwise merge conflict central
That type alias IS used hehe

v0 4w ago

demsem.dev 3w ago

LGTM