templates: create _layout.jinja for actual pages, _base.jinja now for misc. #59

Closed

bwc9876.dev 4w ago

targeting main from ben/init-basic-apps

Closed opened by and assigned to

bwc9876.dev 4w ago targeting main from ben/init-basic-apps

Commits 0

Could not load commits.

Comments

v0 4w ago

huy55465.tngl.sh 4w ago

templates/_base.jinja:10I don't know much about Jinja, but wouldn't this create a <body> nested inside another <body>?

huy55465.tngl.sh 4w ago

But, LGTM.

demsem.dev 3w ago

The body in the block tag is just a label to be used. I think Ben labels his block tags based on the HTML tag containing it i.e. templates/_layout.jinja:6-8.

My understanding comes from the Jinja docs: "all the block tag does is tell the template engine that a child template may override those placeholders in the template."

LGTM

huy55465.tngl.sh 3w ago

Hmm thanks for the explanation. I won't go spam LGTMs for the rest of the 5th-rounds, but I read through and, LGTM for all.

Versions