rs-cli: WIP on auth, switch to anyhow #75

Merged

targeting ben/cli-auth from huy55465/auto-quvvmlqlomom

Merged opened by and assigned to

bwc9876.dev 1d ago targeting ben/cli-auth from huy55465/auto-quvvmlqlomom

Commits 0

Could not load commits.

Comments

v0 1d ago

pkgs/rs-cli/cli.rs:57 Maybe make a TODO to set a default here, once we know hostnames and a few more details.

pkgs/rs-cli/main.rs:20 You can do anyhow::Result here 🤓

Did you run clippy on this? (cargo clippy -- -D warnings --no-deps) it will complain about unused trait imports like anyhow::Context

pkgs/rs-cli/auth.rs:15 anyhow::Context::with_context would be preferred here so it doesn't make the string always

v1 1d ago

whoops, I'm dumb, that didn't compile

v2 1d ago

Otherwise LGTM so far

v3 19h ago

v4 19h ago

That took a lot of rounds...

v5 19h ago

#LGTM