Bluesky app fork with some witchin' additions 馃挮 witchsky.app
bluesky fork client
120
fork

Configure Feed

Select the types of activity you want to include in your feed.

"Display images in higher quality" does absolutely nothing #94

open opened by daniela.lol

a recent bluesky change made it so that all images on bluesky get rendered to the user as webp, this completely broke the work around this tweak did to render the actual blob image file and every image rendered on witchsky are the more low quality bluesky cdn ones as a result, the description this tweak has is also inaccurate now as bluesky no longer shows users jpeg images but rather webp ones (that are still jpeg but whatever)

now i know this is probably gonna get brought up but no, the recent change to witchsky, that being every image thats uploaded gets uploaded as webp does not work around this issue or fix it, now with this witchsky change, instead of every image u upload being first uploaded as a jpeg and then rendered as a lossy webp, now everything gets uploaded as a webp that now gets converted to another webp thats lossy, still resulting to quality loss

the tweak never actually rendered the original blob, it just made the cdn serve a png instead of jpeg. the tweak is pointless now and should be removed (or adjusted to serve the blob, but there are other reasons not to do this: this can overload pdses, and the pds may not serve the blob with the right headers for display, which will break images)

well i just learned that bluesky still serves pngs actually, they just removed the @jpeg thing in the url by default, if u readd @png to a bluesky cdn link it serves u a higher quality image again

so the tweak in fact isnt pointless and can be fixed, doing this gives much better quality results which u can pretty much eyeball

i believe i fixed the code, looked around on my timeline a bit and i didnt see anything break, ill try making a pr

well it looks like tangled isnt letting me make pull requests rn so i guess ill wait

also need to make the Display images in higher quality option work with other appviews/cdns! (reopening for this reason)

i think a problem with other cdns there isnt really an easy way to know if said cdn actually even does the entire lower quality image system or not, for example: cdn.blueat.net (a cdn that actually does animated pfps little fun fact) seems to always default to the most highest quality source (aka the raw blob), which makes even doing the high quality tweak on it completely pointless as its already doing it by default

the blacksky appview still uses @jpeg so the new logic breaks image loading with it

i could probs write an edge case then that checks for jpeg first, i dont use custom appviews so i had no clue about this being an issue

well whenever i can actually use bluesky that is haha, really confused on whats going on even trying to use blacksky or reddwarf is completely fucked and i thought those were completely separate from bluesky?

ah well, finally learned that whats going on is a ddos attack, fun, guess this is gonna be an issue for a while

sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 4
AT URI
at://did:plc:x3vdwseoxbzbp2dfv7q3brqn/sh.tangled.repo.issue/3mjf5hixz5f22