Missing preview.min.js, breaks the preview #54

Closed kento.tngl.sh
Closed opened by and assigned to kento.tngl.sh

Did you forget to check this in?

To view your forest, open http://localhost:8080 in your browser.
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62827
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62828
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62829
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62830
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62831
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62832
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62833
+Server: Eio.Io Fs Not_found Unix_error (No such file or directory, "openat", "/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js"),
+  opening <fs:/Users/jon/.opam/5.4.0/share/forester/themes/default/preview.min.js>,
+  handling connection from tcp:127.0.0.1:62834

Bisection reveals that 5d7129c902eeec5f6a8d9f06663d547886e5a687 the bad commit.

yes, whoops. The plan is to split the js bundle so that the published forest does not ship more JS than needed, which can cut response time by a lot.

Sign up or Sign in to add to the discussion.