Constellation, Spacedust, Slingshot, UFOs: atproto crates and services for microcosm

Fork 8

Convert existing REST /links/count endpoint to XRPC equivalent #41

Closed

microcosm.blue 9mo ago

targeting main from deleted fork:xrpc_backlinks_count

Closed opened by and assigned to

microcosm.blue 9mo ago targeting main from deleted fork:xrpc_backlinks_count

Add getCounts XRPC equivalent to REST /links/count

Simple conversion of the existing endpoint from REST to XRPC. Consequtively marked the pre-existing REST endpoint as deprecated.

In addition we now ignore rocks.test

Commits 0

Could not load commits.

Comments

seoul.systems 9mo ago

Had to do some rebasing and cleanup, but good to go now I think.

bad-example.com 9mo ago

sweet!

(btw the local/ gitignore is there for doing local/rocks.test, but i'm fine adding it to the top-level gitignore too!)

bad-example.com 9mo ago

i think links.getCounts is a little too broad -- what do you think of links.getBacklinksCount?

bad-example.com 9mo ago

we also throw a deprecated warning under /links/count on the main page template, matching the one for /links.

bad-example.com 9mo ago

it's weird but the whitespace in the forms in try-it-macros is significant (one of my moments of knowingly doing things the wrong way because i was bored, sorry!)

the new form for this endpoint needs little tweaking to match the others.

seoul.systems 9mo ago

Ah got it. The rocks tests ended up cluttering the top-level directory so I just added them to .gitignore. I often keep a .local file in .gitignores to ignore whatever's supposed to stay in one's local copy and somehow assumed this had the same intent.

Changed the function and endpoint/method name as requested to get_backlinks_count/getBacklinksCount

The endpoint in the try-it-macro should now match the other existing ones down to how they're formatted with whitespace

seoul.systems 9mo ago

Tangled somehow complains about merge conflicts here, but I couldn't find any after rebasing on upstream/main again?!

bad-example.com 9mo ago

very weird!

one tiny thing left: the source for blocks is app.bsky.graph.block:subject (no .uri suffix on the path) -- it's in the hello.html template.

bad-example.com 9mo ago

i think some many-to-many order stuff ended up on this branch but i'm too tired for git rn.

if you don't get to it first i'm happy to fix the source and git stuff and merge when i can get to it 😃

seoul.systems 9mo ago

Sorry about the the m2m stuff that I didn't catch before opening the PR. I did clean this up again, and nothing belonging there should be remaining here; Addresses your above comment regarding the .uri suffix as well.

v0 9mo ago

seoul.systems 9mo ago

I'm giving up on the whitespace issue...

max@max-mbpro ~/dev/microcosm-rs (xrpc_backlinks_count) $ git diff --check upstream/main
max@max-mbpro ~/dev/microcosm-rs (xrpc_backlinks_count) $

git-diff --checked doesn't indicate any errors either.

As far as I can tell this seems to be a confirmed Tangled issue

bad-example.com 9mo ago

happy to do merging locally as needed!

bad-example.com 9mo ago

merged. thanks!

Versions