Constellation, Spacedust, Slingshot, UFOs: atproto crates and services for microcosm

Fork 8

Convert existing REST /links/distinct-dids endpoint to XRPC equivalent #8 #48

Merged

microcosm.blue 8mo ago

targeting main from deleted fork:xrpc_get_distinct

Merged opened by and assigned to

microcosm.blue 8mo ago targeting main from deleted fork:xrpc_get_distinct

Simple conversion of the existing endpoint from REST to XRPC. Consecutively marked the pre-existing REST endpoint as deprecated.

Commits 0

Could not load commits.

Comments

bad-example.com 9mo ago

i'm getting a compilation error on this branch from the templates -- i think a couple lines got lost from #8

i think the name of this XRPC needs another iteration. it's close to getBacklinks so the name should probably be closer.

pdsls just calls the distinct dids count "repos", and i'm open to taking some inspiration from that. alksjdflkas i don't have a good suggestion right now.

seoul.systems 9mo ago

Sorry for the compilation error. I started basing my own work on the new XRPC count endpoint as a reference. Rebased on main again and verified that the compilation errors are gone now.

Regarding the endpoint name, "Repos" isn't too bad either, but maybe getBacklinkDids is the option that is most self-evident. So I might go with that.

Feel free to merge if you agree. If you don't think that's a good idea, just let me know. 😃

seoul.systems 9mo ago

The merge conflict label seems to stem from a whitespace related error even though the patch applies cleanly locally. Asking in the Tangled Discord it seems that should've been just a warning instead?

seoul.systems 9mo ago

git-merge-tree doesn't show any conflicts either. A bit lost what to do tbh

oppi.li 9mo ago

lemme have a closer look at why!

seoul.systems 9mo ago

thanks 😃

oppi.li 9mo ago

this is an issue on our end, and has been fixed in this PR: https://tangled.org/tangled.org/core/pulls/1033 . I will try to get this merged and deployed shortly, and that should automagically unblock this PR!

seoul.systems 9mo ago

Sounds great!

bad-example.com 9mo ago

i think that's a good name. going to sleep on it before merging.

thanks!

oppi.li 8mo ago

the bug here should be fixed now! the pending conflict is because both files have been modified, sorry for the long wait!

seoul.systems 8mo ago

fixed the remaining conflicts and the PR seems good to go now. Thanks for the follow up 😃

bad-example.com 8mo ago

sorry for getting the PRs mixed up! i'll do a final pass on this tomorrow, it's looking great. two clippy lints (from make check in the repo root):

#[deprecated]: please put a comment instead of using the rust-level marker (which is very cool!). the deprecations in the server code are mostly notices to client using, not internal code (like the web server) 😃
unnecessary & on line 728 for the &collection param (just remove the &).

(i gotta get tangled CI going here!)

bad-example.com 8mo ago

^^ line 728 of server/mod.rs

seoul.systems 8mo ago

Fixed 😃

bad-example.com 8mo ago

managed to get it conflicting again after merging #7, sorry! i'm good to go with this otherwise.

i'll let you resolve and resubmit, so it says "merged" on your pr in tangled if you want. realized it wasn't doing that when i was merging manually otherwise.

(but i'm happy to resolve conflicts and merge that way if it's the same to you or if you don't have time to get the changes!)

seoul.systems 8mo ago

I resolved the conflict and now things should be ready to merge again

v0 8mo ago

bad-example.com 8mo ago

thanks!!

Versions