this repo has no description
internal/core/adt: remove completeNodeTasks from doDisjunct
The call to completeNodeTasks before forking a disjunct
overlay was intended to flush pending parent work before
the copy is made. This is now handled by the handleParents
mechanism in process(); keeping the call caused redundant
work and risked double-completing nodes.
Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I29e1cb24dfdc2ff7a2f032634363434562b59716
Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1236177
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
-5
-5
internal/core/adt/disjunct2.go
-5
internal/core/adt/disjunct2.go
···
530
530
531
531
oc := newOverlayContext(n.ctx)
532
532
533
-
// Complete as much of the pending work of this node and its parent before
534
-
// copying. Note that once a copy is made, the disjunct is no longer able
535
-
// to receive conjuncts from the original.
536
-
n.completeNodeTasks(mode)
537
-
538
533
// TODO: we may need to process incoming notifications for all arcs in
539
534
// the copied disjunct, but only those notifications not coming from
540
535
// within the arc itself.