swift-tangled
A practical Tangled CLI nnabeyang.tngl.sh/swift-tangled
tangled atproto cli
Star 8
Fork 0
Watch

fix: send repository DIDs for fork resubmission #207

Merged nnabeyang.tngl.sh
targeting main from fix/fork-resubmit-repository-did
Merged opened by and assigned to nnabeyang.tngl.sh
targeting main from fix/fork-resubmit-repository-did

Summary #

Fix regular and stacked fork pull request resubmission by sending the source repository DID required by the current hidden-ref API.

Background #

Tangled's repository write APIs now identify repositories by repository DID. The released CLI still sent the fork repository's AT URI to sh.tangled.repo.hiddenRef, so current Knots rejected fork pull request resubmission before a new round could be created.

This change updates the generated request type and keeps repository identification consistent through the resubmission services and KnotClient.

References Issue #6.

Validation #

  • End-to-end fork resubmission against knot1.tangled.sh using norikey.tngl.sh/tng-playground pull request #26
    • reproduced the invalid repo DID failure with the released tng 0.6.0
    • resubmitted the same fork flow with this branch's development build
    • verified that round 1 was created and its cumulative diff could be read back
Commits 0