log client errors with better context #56

Merged

nonbinary.computer 11mo ago

targeting main

Merged opened by and assigned to

nonbinary.computer 11mo ago targeting main

This pull request has no versions submitted yet.

Comments

nekomimi.pet 11mo ago

theres also a lot of debug logging that seemingly got left in like

@@ -1081,8 +1081,6 @@ pub trait AgentSessionExt: AgentSession + IdentityResolver {
-            let debug: serde_json::Value = serde_json::from_slice(response.buffer()).unwrap();
-            println!("json: {}", serde_json::to_string_pretty(&debug).unwrap());

and

@@ -280,8 +280,6 @@ where
-                dbg!(&client_data);

which pollutes the terminal output

nonbinary.computer 11mo ago

Yeah, good call. I'll merge this and then have a good once-over on the errors, there's a bunch of wording and so on i could improve.