lichen.page.view
Reading copy of lichen.page.review: one PR per unit, product changes only
Star 0
Fork 0
Watch

OCTOBER-REVIEW-REVISIONS 5b: the seam traits are inlined #47

Closed notplants-bot.bsky.social
targeting base/october-review-revisions-u5b from view/october-review-revisions-u5b
Closed opened by and assigned to notplants-bot.bsky.social
targeting base/october-review-revisions-u5b from view/october-review-revisions-u5b

The eleven seam traits and PublishOpener are removed; each is inlined into its single shipped implementation: StorageBudget into OwnBudget, WeightChanged into TellTheFront, and PublishTold, OwnerCredentials, Owners and Sites into their Own* types, while the publish takes a PublishSite. FirstStart, Handoff and Handed (whose implementations were no-ops) are deleted, and MainMoved and ToItsRemote become direct outbound::moved calls. MainCalls is kept, because both its implementations (OwnMain, ThenTheHub) ship; it moves to git/hub.rs. Data types move to their users, site_seams.rs and git/seams.rs are gone, and lichen-server's front_seams.rs keeps only its shipped forwarding.

OCTOBER-REVIEW-REVISIONS, subunit 5b. Plan: https://tangled.org/notplants-bot.bsky.social/lichen-orchestrator/blob/main/machine-docs/plans/OCTOBER-REVIEW-REVISIONS-2026-10-28.md

This is a reading copy: only this subunit's product changes, applied in order on its base. Nothing here is to be merged.

Source PRs on lichen.page.review (product), in order, with their original descriptions #

  • #3408 s/776-orr-u5b-no-seams — ORR 5b: no seams (inlined, deleted, or one kept with its reason)

    OCTOBER-REVIEW-REVISIONS unit 5b, product: no seams (C1). The 11 seam traits and PublishOpener go, but for one kept with a reason.

    • Inlined into their one shipped implementation:
      • StorageBudget → OwnBudget in site_process/admin.rs;
      • WeightChanged → TellTheFront in link.rs (the front's FrontWeight becomes allowance::changed);
      • PublishTold, OwnerCredentials, Owners (OwnOwner), Sites (the routes take OwnSite);
      • PublishOpener (the publish takes a PublishSite).
    • Deleted: FirstStart, Handoff and Handed, whose only shipped implementations were no-ops. MainMoved and ToItsRemote become direct outbound::moved calls.
    • Kept, named for what it does: MainCalls, since two implementations ship and both are used through it (OwnMain and ThenTheHub). It moves to git/hub.rs.
    • Data types to their users:
      • SiteArea → admin_area.rs;
      • FIRST_START → hub_repo.rs;
      • SiteFacts and SiteHandle → git.rs;
      • RESTARTING → site_process/admin.rs;
      • what is left of asks.rs → acts/asks.rs, beside the router most of its asks name.
    • Files gone: site_seams.rs and git/seams.rs. lichen-server's front_seams.rs keeps only its shipped forwarding (no traits, no stand-ins) until unit 6 moves it to forwarder/.
    • Not in this unit: SiteHost, which unit 5d (one site, one slot) changes.

Commits #

  • 590268d97 ORR 5b: orr-u5b-no-seams (#3408)

Count and shas #

count-product-code-lines 83ef1b3a191f..590268d9779c: NET -710 · counted +453 -1163 · moved out of the counted set +0 · comment-only deletions flagged 23 · macros flagged 0 · tests-folder code flagged 0

Base 83ef1b3a191fa3172278cdfc9a5abf7e6e536eff (tip of s/775-orr-u5a-tests-home-tests). Head 590268d9779cc2d1654c2563c7957ec0156bea18. 41 files changed.

Check #

Every changed file is a file one of the product PRs changed, and each is identical at the head to the same file at the last product branch s/776-orr-u5b-no-seams. Files that differ from the subunit's top branch s/777-orr-u5b-no-seams-tests: crates/lichen-server/src/admin_area.rs.

Commits 0