Reading copy of lichen.page.review: one PR per unit, product changes only

OCTOBER-REVIEW-REVISIONS 6c: lichen-server's files move into folders by job #51

targeting base/october-review-revisions-u6c from view/october-review-revisions-u6c
Closed opened by and assigned to notplants-bot.bsky.social
targeting base/october-review-revisions-u6c from view/october-review-revisions-u6c

lichen-server's source files are moved into folders by job, with no change to behaviour.

  • forwarder/: forwarder.rs (from front_seams.rs) is the core forwarding with the forwarding routes of server.rs; forwarder/git.rs holds smart HTTP, the editor's git panel, rewrite, force push and auto-pull; forwarder/publish.rs comes from publish/front.rs; forwarder/dashboard.rs holds site_act, SITE_ACTS, remote_shown and hub_status. The old git.rs, git/ and publish.rs go.
  • dashboard/: app.rs, source.rs and ssr.rs (from sign_in_render.rs); lichen-cli names the new path.
  • The git feature is gated once: the gated halves live in api/with_git.rs and tests/features/with_git.rs, and gate lines drop from 26 to 12 in api.rs, 17 to 6 in server.rs and 39 to 2 in tests/features.rs.
  • The default build without git works: the publish's forward to the admin thread moves into the core of forwarder.rs, and hub_act is gated by git.

OCTOBER-REVIEW-REVISIONS, subunit 6c. Plan: https://tangled.org/notplants-bot.bsky.social/lichen-orchestrator/blob/main/machine-docs/plans/OCTOBER-REVIEW-REVISIONS-2026-10-28.md

This is a reading copy: only this subunit's product changes, applied in order on its base. Nothing here is to be merged.

Source PRs on lichen.page.review (product), in order, with their original descriptions #

  • #3417 s/786-orr-u6c-server-moves — ORR 6c: lichen-server's moves (forwarder/, dashboard/; the git feature gated once)

    OCTOBER-REVIEW-REVISIONS unit 6c, product: lichen-server's moves, one PR for the crate. Moves only; renames are unit 7's.

    • forwarder/ (A6):

      • forwarder.rs (from front_seams.rs) is the core forwarding, with server.rs's forwarding routes;
      • forwarder/git.rs (from git.rs, gated once) holds smart HTTP, the editor's git panel, rewrite, force push and the auto-pull;
      • forwarder/publish.rs comes from publish/front.rs;
      • forwarder/dashboard.rs holds site_act, SITE_ACTS, remote_shown and hub_status.

      lichen-server's git.rs, git/ and publish.rs go, and so does 5b's as publish test re-export.

    • dashboard/ (D4): dashboard/app.rs, dashboard/source.rs and dashboard/ssr.rs (from sign_in_render.rs, as a file move; item renames are unit 7's). lichen-cli names the new path.

    • The git feature, gated once (D6): the gated halves are in api/with_git.rs and tests/features/with_git.rs. Gate lines go 26→12 in api.rs, 17→6 in server.rs and 39→2 in tests/features.rs. The cfg mod lines are in a commit of their own.

    • The default build, without git (A6b): the publish's forward to the admin thread moves into forwarder.rs's core, and hub_act is gated by git. The four default-feature cargo checks (lichen-site and lichen-server, lib and --tests) are rc 0.

    • A7 for lichen-server: not done, for your call. After 2c, lichen-server has no ipc/. What is left is the channel code in site_process/front.rs. Moving it to a root ipc/ would widen about a dozen private SiteProcess fields to pub(crate), and workspace_structure pins the control channel's one reader and writer to that file.

    • AST, on lichen-ci (per-sha, notify-8c3c59e5): every move pair is rc=0 equal=True errors=0:

      • R: the retired re-exports;
      • A6: 26 moved, 19 files renamed;
      • D4: 6 renamed;
      • D6: 54 moved;
      • D5a: 4 tests;
      • D5b: 2 renamed;
      • A6b: 3 moved.

Commits #

  • e7b00b2ae ORR 6c: orr-u6c-server-moves (#3417)

Count and shas #

count-product-code-lines cf63d64a2e75..e7b00b2aebdf: NET -540 · counted +1996 -2536 · moved out of the counted set +0 · comment-only deletions flagged 11 · macros flagged 0 · tests-folder code flagged 0

Base cf63d64a2e759699523523e6f364ee89de14ac7b (tip of s/785-orr-u6b-site-moves-tests). Head e7b00b2aebdf81a94ebe408b7ea21fdb1365eb9c. 33 files changed.

Check #

Every changed file is a file one of the product PRs changed, and each is identical at the head to the same file at the last product branch s/786-orr-u6c-server-moves.

Commits 0