OCTOBER-REVIEW-REVISIONS 8b: lint fixes from the closing standard #54

Lint fixes found by the closing standard. atproto/tests/stand_in.rs gets narrow #[allow(..., reason = ...)] attributes (it is compiled under test-support as well as cfg(test) and so was linted as product code). The two remove_file calls and the create_dir_all in git/hub.rs that touch the site's own .git and .lichen/tmp carry the allow-with-reason that clippy.toml prescribes for those paths. Leftovers are cleaned: the dead fn packed is deleted, a needless return in outbound.rs and an explicit auto-deref in host.rs are removed, and the unused pub use with_git::* in api.rs goes. Lint levels are unchanged.

---

OCTOBER-REVIEW-REVISIONS, subunit 8b. Plan: https://tangled.org/notplants-bot.bsky.social/lichen-orchestrator/blob/main/machine-docs/plans/OCTOBER-REVIEW-REVISIONS-2026-10-28.md

This is a reading copy: only this subunit's product changes, applied in order on its base. Nothing here is to be merged.

Source PRs on lichen.page.review (product), in order, with their original descriptions #

• #3424 s/793-orr-u8b-standard-fixups — ORR 8b: the closing standard's clippy reds (a test-support stand-in, hub.rs's .git paths) and ORR's leftovers

  ORR unit 8b, product: the closing standard's reds (notify-95805416 at ccb40e42 --base 65a6666b). Per TESTING-STRATEGY these are the phase-end standard's to find; the per-unit runs carry no clippy.

  • clippy, atproto/tests/stand_in.rs (5c):
    • The file is compiled under test-support as well as cfg(test). lichen-server's dev-dependency turns test-support on in clippy's --all-targets build, so it was linted as product code.
    • Each start gets a narrow #[allow(..., reason = "test-support: …")], as runtime.rs and inject.rs do: expect_used on all three, and disallowed_methods on the two that call Router::route.
    • clippy.toml and the lint levels are unchanged.
  • clippy, git/hub.rs (1c):
    • The two remove_file calls and the create_dir_all touch the site's own .git and .lichen/tmp, which are outside its file tree.
    • They carry the allow-with-reason that clippy.toml prescribes for those paths, as the same file already does at its reset mark.
    • The sabotage-write-gate lane's three extra errors were these; it counts its six plants again.
  • ORR's leftovers:
    • the dead fn packed (2b), deleted;
    • a needless return in outbound.rs (5c);
    • an explicit auto-deref in host.rs (2a);
    • api.rs's pub use with_git::*, which exported nothing public, is now pub(crate) use (6c).
  • Not touched: the base-era clippy warnings; blame puts each one before 65a6666b.
  • Merged in: unit 8 docs round 1 (7225c4bc).

  On lichen-ci:

  • notify-bc051da1 at 56091fd4:
    • fmt 0;
    • clippy, all 7 crates, rc 0 with 0 errors;
    • the sabotage gate rc 0, every plant refused;
    • test_c2_offline.py 94 passed;
    • custom 56/56.
  • notify-baea502a at 0d5c12d5: clippy rc 0, custom 58/58.
  • The merge of 7225c4bc changes one comment and nothing else.

Commits #

• c361aaa96 ORR 8b: orr-u8b-standard-fixups (#3424)

Count and shas #

count-product-code-lines 7225c4bc750c..c361aaa96cc7: NET -5 · counted +11 -16 · moved out of the counted set +0 · comment-only deletions flagged 1 · macros flagged 0 · tests-folder code flagged 0

Base 7225c4bc750c5439e1e0bd4596d851f280e58e5c (tip of s/792-orr-u8-docs). Head c361aaa96cc7b10d7f0fe4773454294e3a6a1c2f. 5 files changed.

Check #

Every changed file is a file one of the product PRs changed, and each is identical at the head to the same file at the last product branch s/793-orr-u8b-standard-fixups.