Reading copy of lichen.page.review: one PR per unit, product changes only

OCTOBER-REVIEW-REVISIONS 7b: flatten site_process and apply the naming guideline #55

targeting base/october-review-revisions-u7b from view/october-review-revisions-u7b
Open opened by and assigned to notplants-bot.bsky.social
targeting base/october-review-revisions-u7b from view/october-review-revisions-u7b

lichen-server's site_process/ is flattened and unit 7's new names are checked against the naming guideline. site_process/front.rs's 41 items move into site_process.rs, and the placeholder site_process/front/channel.rs becomes site_process/control_channel.rs. Renames: socket_tx to pass_socket_end, SUPERVISED to IS_SUPERVISED_PROCESS, ProcessCgroup to SupervisedProcessCgroup (and process_cgroup to supervised_process_cgroup), asked_fd to process_socket_fd, apply_sandbox_filters to apply_seccomp_filters. References, docs/SECURITY.md and lichen-site's sandbox_profiles.rs follow.


OCTOBER-REVIEW-REVISIONS, subunit 7b. Plan: https://tangled.org/notplants-bot.bsky.social/lichen-orchestrator/blob/main/machine-docs/plans/OCTOBER-REVIEW-REVISIONS-2026-10-28.md

This is a reading copy: only this subunit's product changes, applied in order on its base. Nothing here is to be merged.

Source PRs on lichen.page.review (product), in order, with their original descriptions #

  • #3426 s/795-orr-u7b-flatten-site-process — ORR 7b: lichen-server's site_process/ flattened (control_channel.rs); unit 7's names to the naming guideline

    ORR unit 7b, the operator's addition to unit 7 (2026-10-30; plan unit 7 and NAMING-GUIDELINE.md): flatten lichen-server's site_process/, and apply the naming guideline to unit 7's own new names. Moves and renames only.

    • Flatten:

      • site_process/front.rs's 41 items move into site_process.rs itself.
      • 6c's placeholder site_process/front/channel.rs becomes site_process/control_channel.rs.
      • Module docs move in a comments-only commit.
      • References, docs/SECURITY.md and lichen-site's sandbox_profiles.rs follow.
    • Naming review, against NAMING-GUIDELINE. Uniqueness is by git grep -w across the workspace; the full table is in the ledger record.

      Old New Why
      socket_tx pass_socket_end _tx is a channel sender everywhere else here
      SUPERVISED IS_SUPERVISED_PROCESS says what the flag records
      ProcessCgroup SupervisedProcessCgroup any process has a cgroup
      process_cgroup supervised_process_cgroup as above
      asked_fd process_socket_fd the notifying process's socket
      apply_sandbox_filters apply_seccomp_filters its doc and the structure test call them seccomp filters
      • Kept, each unique and clear: front_render_spec and its constant and arg, socket_request, socket_serve, supervised_command, the *_supervised_process functions, and control_channel.
    • AST check on lichen-ci (per-sha, notify-e4380147): all 8 ranges equal=True errors=0. That covers the flatten (moved=41 carried=38 files_renamed=2), the five renames, a test constant rename and a whitespace wrap. The comments-only and rustfmt commits were checked by script.

    • Merged in: fix-up 8b (38ade515).

    Raised for the operator, not changed here:

    • site_process still names both sides, lichen-server's and lichen-site's. The guideline's rule 2 names exactly this pair, but the plan names site_process.rs.
    • MemoryBound::supervised_process_cgroup (a method) and memory::supervised_process_cgroup (a function) share a name, as they did before unit 7. The AST checker's rewrites are per file, so renaming only one cannot be move-checked. (…cut here; the full text is on the PR page.)

Commits #

  • af482ae5c ORR 7b: orr-u7b-flatten-site-process (#3426)

Count and shas #

count-product-code-lines 726fb7d71df8..af482ae5c925: NET -2 · counted +1493 -1495 · moved out of the counted set +0 · comment-only deletions flagged 10 · macros flagged 0 · tests-folder code flagged 0

Base 726fb7d71df8aa72c3d50a978ddf654d26aa2ad1 (tip of s/794-orr-u8b-standard-fixups-tests). Head af482ae5c9250bd51a82adb0720f78b392a43e2c. 18 files changed.

Check #

Every changed file is a file one of the product PRs changed, and each is identical at the head to the same file at the last product branch s/795-orr-u7b-flatten-site-process.

Resolved/noted: #3426: parent s/794-orr-u8b-standard-fixups-tests is not an ancestor of s/795-orr-u7b-flatten-site-process; diffed against the merge base

Commits 0