https://radio.wisp.place radio for my friends and i

Fork 3

Add Docker support for radio #17

Merged

okami.mom 3mo ago

targeting master

Merged opened by and assigned to

okami.mom 3mo ago targeting master

Submitting my personal Dockerfile that I used to host my own radio station with. Tested on both an x86_64 server and an Apple Silicon device. Also included a small piece of information on how to use the Dockerfile.

This pull request has no versions submitted yet.

Comments

did:plc:wdw23cmxchtwm553f2jwukmz 2mo ago

Review: Docker support patch #

Scope/limits: patch-only mode. /workspace/source is empty and no repository checkout or Docker/Compose daemon is available, so I could not build the image, run docker compose, or verify the assumed project layout (frontend/, static/, migrations/, Cargo.lock, binary name radio, env var names). Findings below are static review of the submitted patch.

Findings #

compose.yml:10 and compose.yml:12-13 — declared named volume is unused; bind mount will likely break non-root runtime The service mounts a bind mount:
```
volumes:
  - ./radio-data:/app/data
```
but the file also declares a named volume:
```
volumes:
  radio-data:
```
radio-data is never referenced by the service, so the named volume is created but unused. More importantly, the bind mount masks the chown -R radio:radio /app done in Dockerfile:45. On Linux hosts, when ./radio-data does not exist, Docker creates it as root:root (0755), and the container process runs as UID 10001 (USER radio), so it cannot create /app/data/radio.db or write under /app/data/audio; the app can fail with SQLite/audio permission errors.

If the named volume is intended, use:
```
volumes:
  - radio-data:/app/data
```
If the bind mount is intended, remove the top-level volumes: block and document that the host directory must already exist and be writable by UID 10001, or pre-create it with chown 10001:10001.
.dockerignore:1-8 — missing radio-data exposes persistent audio/DB data to the build context The Compose bind mount uses ./radio-data, but .dockerignore only ignores target, frontend/node_modules, frontend/dist, static, data, .env, .git, and *.db. After the first docker compose up, ./radio-data exists on the host and is not excluded from the Docker build context. COPY . . at Dockerfile:22 will then send that directory to the daemon and store it in the backend-builder layer/build cache. This can bloat builds and leak private audio/DB contents into Docker build state. Add radio-data (and any other runtime data path) to .dockerignore.
Dockerfile:24-26 — static replacement is destructive and glob-lossy
```
RUN rm -rf ./static/* 2>/dev/null
RUN mkdir ./static
RUN mv ./frontend/dist/* ./static/
```
This removes any committed static/ assets rather than layering the built frontend over them. It also uses a shell glob, which will not move dotfiles from frontend/dist, and fails if dist is empty. It only works currently because static is excluded by .dockerignore; if that changes, mkdir ./static will fail because the directory already exists. Prefer something like:
```
RUN rm -rf ./static && mkdir -p ./static && cp -a ./frontend/dist/. ./static/
```
or otherwise confirm that all runtime static content is generated by the frontend build.
Dockerfile:7 — npm install is not reproducible If frontend/package-lock.json is committed, use npm ci instead of npm install for a clean, lockfile-based install. If there is no lockfile, builds can pull different dependency versions over time. This is not a hard correctness failure, but it is a supply-chain/reproducibility concern.

Unverified assumptions #

Dockerfile:28 uses cargo build --release --locked; this requires a committed Cargo.lock. If the repository does not commit one, the build will fail.
Dockerfile:41-43 assumes the release binary is /app/target/release/radio and that static/ and migrations/ exist at the repo root. These could not be verified without the source tree.
Dockerfile:51-53 assumes the application honors BIND_ADDR, DATABASE_URL, and AUDIO_DIR exactly as spelled. These env names could not be checked against the source.

reviewed by weaver · model: deepseek-v4-pro automated review; not independently verified. patch-only limitation: original source fork or commit is unavailable; review is limited to the submitted patch. no complete source checkout was available; repository builds and tests were not verified.

okami.mom 2mo ago

sorry i used this PR to test my tangled bot

did:plc:wdw23cmxchtwm553f2jwukmz 2mo ago

Review draft — Docker support PR #

Scope/limitations: static review only. The pinned /workspace/source snapshot already contains these Docker files, so line numbers below are from that snapshot. I did not run docker build/docker compose because no Docker/network is available in the review VM; runtime behavior is inferred from the files and application source.

1. High: compose uses a root-owned bind mount with a non-root container user #

compose.yml:9-10 uses ./radio-data:/app/data, while Dockerfile:45-47 creates /app/data and then switches to USER radio (UID 10001).

On a normal Linux Docker host, when ./radio-data does not exist, the daemon creates it as root. The container then runs as UID 10001, so it cannot create /app/data/radio.db or /app/data/audio:

With Dockerfile’s DATABASE_URL=sqlite:///app/data/radio.db, startup fails opening the DB.
With the documented quickstart (.env overriding DATABASE_URL), startup may succeed but audio uploads fail when the app calls tokio::fs::create_dir_all(self.audio_dir) at src/radio/service.rs:1262.

The declared named volume radio-data (compose.yml:12-13) is never referenced. Use - radio-data:/app/data, or if the bind mount is intentional, pre-create/chown ./radio-data and/or set a matching user: in compose.

2. High: `env_file` overrides the Dockerfile’s absolute DB/audio paths, putting the database outside the volume #

compose.yml:8 loads .env, and the README quickstart says cp .env.example .env (README.md:43-44). That file contains:

DATABASE_URL=sqlite://radio.db (.env.example:16)
AUDIO_DIR=data/audio (.env.example:18)

Runtime env_file values take precedence over image ENV, so they override the Dockerfile defaults at Dockerfile:51-53. With WORKDIR /app, DATABASE_URL=sqlite://radio.db resolves to /app/radio.db, outside /app/data and outside the declared volume. The result is a database that is not persisted across container recreation even though the intent is clearly for /app/data to hold state.

Fix by adding environment: overrides in compose for DATABASE_URL and AUDIO_DIR (which take precedence over env_file), or by changing the Docker README/.env guidance to use absolute paths.

3. Medium: `.dockerignore` misses `.env.local`, `radio-data`, and root `node_modules` #

.dockerignore:6 excludes only .env. The backend explicitly loads .env.local (src/main.rs:108), so a developer’s .env.local would be sent to the Docker daemon and copied into the backend-builder layer by COPY . . (Dockerfile:22), potentially exposing secrets in build cache/intermediate layers.

Also, compose.yml:10 creates ./radio-data on the host, but radio-data is not in .dockerignore. On subsequent builds that directory (possibly containing the station DB and uploaded audio) is sent as build context and copied into the builder. Root node_modules is likewise not ignored if someone runs npm install at the repo root.

Recommend adding at least:

.env*
radio-data
**/node_modules
*.db-shm
*.db-wal

4. Low: runtime image is missing `ffmpeg` and `yt-dlp` #

The runtime installs only ca-certificates and libssl3 (Dockerfile:33-37), but the application shells out to:

ffmpeg in src/loudness.rs:15 and src/tempo.rs:37
yt-dlp in src/routes/upload.rs:59 / :96 and src/metadata.rs:67

Loudness/tempo backfills will only log background warnings, but URL imports and yt-dlp metadata/cover lookup will fail in the container. If Docker is expected to match the non-Docker feature set, install ffmpeg and yt-dlp, or explicitly document these limitations.

5. Low: use `npm ci` instead of `npm install` #

Dockerfile:7 runs npm install, but frontend/package-lock.json exists. npm ci would give reproducible installs and fail clearly if the lockfile is out of sync.

6. Low/optional: `ports` binds on all host interfaces #

compose.yml:6-7 exposes 3000:3000 on 0.0.0.0. If the reverse proxy runs on the same host, binding to 127.0.0.1:3000:3000 is safer and still sufficient.

reviewed by weaver · model: deepseek-v4-pro automated review; not independently verified. repository context: original source fork or commit is unavailable; pinned target repository snapshot 2f6042bfa314d0ae4de8c92ce258901410c64fd9 is context, not an exact PR checkout; the immutable submitted patch remains unapplied. target snapshot: 2f6042bfa314d0ae4de8c92ce258901410c64fd9. this is not the original pr checkout; checks against this snapshot are not exact pr verification.

Review: Docker support patch #

Findings #

Unverified assumptions #

Review draft — Docker support PR #

1. High: compose uses a root-owned bind mount with a non-root container user #

2. High: env_file overrides the Dockerfile’s absolute DB/audio paths, putting the database outside the volume #

3. Medium: .dockerignore misses .env.local, radio-data, and root node_modules #

4. Low: runtime image is missing ffmpeg and yt-dlp #

5. Low: use npm ci instead of npm install #

6. Low/optional: ports binds on all host interfaces #

2. High: `env_file` overrides the Dockerfile’s absolute DB/audio paths, putting the database outside the volume #

3. Medium: `.dockerignore` misses `.env.local`, `radio-data`, and root `node_modules` #

4. Low: runtime image is missing `ffmpeg` and `yt-dlp` #

5. Low: use `npm ci` instead of `npm install` #

6. Low/optional: `ports` binds on all host interfaces #