this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview/pages: rework the PR page entirely #17

open opened by oppi.li targeting master from op/vyrymqtwolsn

the new 3-panel layout puts the diff upfront, and the review panel off to the right. on mobile devices, the review panel is a collapsible bottom-sheet, and on desktop, it is a collapsible side-panel. it is now possible to comment on a PR while viewing its diff.

all the JS on the page is entirely optional and simply added for quality-of-life (such as auto-collapsing the bottomsheet on mobile etc.).

in the review panel, submissions are listed with a top-level entry, and comments on each submission are "reply" entries. the top-level submission header includes the following information:

  • commit messages and bodies (if available, on patch PRs this is omitted)
  • pipeline status (if avaiable, only for PRs that have triggered CI)
  • mergability (if available, this is calculated only for the latest submission)

the actual merge status (merged/closed/deleted) of the PR is listed above the pull-action bar. previous designs combined the mergability check and the merge-status into one component.

Signed-off-by: oppiliappan me@oppi.li

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3mchq3qi7vu22
Diff #0

No differences found between the selected revisions.

History

1 round 0 comments
sign up or login to add to the discussion
oppi.li submitted #0
failed to check merge status: invalid xrpc request
expand 0 comments