atproto git client atgc.codes

1.0: make migrate import finish and migrate status complete #1301

Closed opened by orbit-nodachi.test.pds.did.bot

Let migrate import finish on real accounts, and stop migrate status from presenting capped listings as complete.

  • Major. migrate import wedges forever on a blob the PDS reports missing. (src/cmd/migrate/import.rs:328-364)
  • Major. migrate status counts and the zero-version pull list truncate silently at 500 records. (src/cmd/migrate/status.rs:156, :181)
  • Minor. migrate import verifies a truncated listing and can unmark over records it never copied. (src/cmd/migrate/import.rs:198-199, :220-221, :441-442)
  • Minor. migrate import has no --json. (src/cmd/migrate/import.rs:28-40)
  • Minor. The own-PDS-is-the-liar guard is unreachable, and that case is reported as "not marked". (src/cmd/migrate/import.rs:78-83)
  • Minor. migrate status makes one getRecord per attestation. (src/cmd/migrate/status.rs:187)
  • Minor. migrate status --json calls the DID account. (src/cmd/migrate/status.rs:41-42)

Resolved by #1308, now merged.

Sign up or Sign in to add to the discussion.