1.0: make pr and issue reads consistent and honest · Issue #1302 · permadeath.com/atgc

Give pr and issue reads one parser, one exit-code mapping and one JSON shape, and stop them showing failed reads as zero.

Major. pr list --all and issue list --all silently ignore --repo. (src/cmd/pr/read/mod.rs:86-88; src/cmd/issue/read.rs:313)
Major. pr view --comments from Bobbin prints replies before their parents. (src/clients/tangled/bobbin/mod.rs:408-419)
Major. A missing pull exits 1 on the Bobbin path. (src/cmd/pr/read/tickets.rs:34-39)
Major. --author is accepted and ignored on pr view/diff/checks/comment and issue comment. (src/cmd/pr/read/mod.rs:537-539; src/cmd/pr/review.rs:225-227; src/cmd/pr/checks.rs:25-27; src/cmd/pr/write.rs:1273-1275; src/cmd/issue/write.rs:441-465)
Major. pr diff --max-bytes does nothing. (src/cmd/pr/review.rs:243-246)
Major. issue view --json has no ticket url, and issue JSON shapes differ from pr's. (src/cmd/issue/read.rs:653, :832-858, :976)
Minor. The thread note credits Bobbin for knot comments and hides the 100-comment cap. (src/cmd/mod.rs:203-208)
Minor. pr view --json versions carry no base, head or source branch. (src/cmd/pr/read/mod.rs:192-201)
Minor. pr checks on a pull with no versions exits 1. (src/cmd/pr/checks.rs:60-71)
Minor. pr checks --json calls the at-uri pull. (src/cmd/pr/checks.rs:45-55)
Minor. Failed version and comment reads show as 0. (src/cmd/pr/read/mod.rs:683-735)
Minor. An empty listing drops the index-lag caveat. (src/cmd/pr/read/mod.rs:475-499)
Minor. Help offers a bare TID record key the parser rejects. (src/cmd/pr/mod.rs:161; src/cmd/ticket_ref.rs:236-239)
Minor. --no-pager is ignored by --interdiff. (src/cmd/pr/review.rs:345-354)
Minor. Unreachable checks, an unused enum field and old pr module docs. (src/cmd/pr/review.rs:276-281; src/cmd/mod.rs:152-158; src/cmd/pr/mod.rs:1-30)
Minor. pr checks may show a pipeline that is not the pull's own run. (src/cmd/pr/checks.rs:77)
Minor. issue view has its own ticket parser. (src/cmd/issue/read.rs:82-217)
Minor. A scheme-less URL ending in /issues is parsed as the record key "issues". (src/cmd/ticket_ref.rs:225-234)