atproto git client atgc.codes

1.0: make ticket state, edit and comment writes safe and consistent #1303

Closed opened by orbit-nodachi.test.pds.did.bot

Make ticket and comment writes respect merged pulls, accept --repo, check the right scopes in dry runs, and validate before reporting success.

  • Major. pr close/reopen turn a merged pull back into closed or open. (src/cmd/ticket_state.rs:61)
  • Major. pr edit and issue edit reject --repo. (src/cmd/pr/write.rs:1184-1216; src/cmd/issue/write.rs:368-397; src/cmd/ticket_edit.rs:122)
  • Major. comment --edit/--delete and --reply-to demand a checkout even with an at:// URI. (src/cmd/comment.rs:230, :335; src/cmd/issue/write.rs:556-560)
  • Major. comment --delete --dry-run checks putRecord, not deleteRecord. (src/cmd/comment.rs:350)
  • Minor. issue create/edit --dry-run accept bodies the knot will refuse. (src/cmd/issue/write.rs:228-237; src/cmd/ticket_edit.rs:227-236)
  • Minor. close/reopen --dry-run fails on a missing scope instead of warning. (src/cmd/ticket_state.rs:72-78)
  • Minor. Write confirmations print the ticket title raw. (src/cmd/ticket_state.rs:148; src/cmd/ticket_edit.rs:175-177; src/cmd/issue/write.rs:624)
  • Minor. A blank issue title suggests "or commit with a subject". (src/cmd/mod.rs:315-318)
  • Minor. close/reopen --json leave out url. (src/cmd/ticket_state.rs:134-145)
  • Minor. pr close/reopen/edit/comment help runs its examples together. (src/cmd/pr/mod.rs:237, :246, :255, :266)
  • Minor. pr edit calls the target branch --base. (src/cmd/pr/write.rs:1208)
  • Minor. comment --edit's pre-flight leaves out the attestation scope. (src/cmd/comment.rs:283)
  • Minor. A valid image title containing ]( is refused. (src/cmd/images.rs:183)
  • Minor. Oversized images are read into memory before the 1 MB check. (src/cmd/images.rs:281-297)
  • Minor. Dead comment parser and old docs in the comments client. (src/clients/tangled/comments.rs)
  • Minor. Comment docs promise pullRoundIdx and appview ingestion. (src/cmd/pr/write.rs:1344; src/cmd/issue/write.rs:500-503)
  • Minor. pr comment --dry-run's image line is one column off. (src/cmd/pr/write.rs:1470)

Resolved by #1309, now merged.

Reopening: one item is still open. pr close and pr reopen still turn a merged pull back into closed or open; src/cmd/ticket_state.rs refuses only when the state already matches, and knot2 has no guard either. A fix is on the way.

Resolved by #1414, now merged.

Sign up or Sign in to add to the discussion.