atproto git client atgc.codes

1.0: make pr create, resubmit and stack marks push to the right place and give advice that works #1304

Closed opened by orbit-nodachi.test.pds.did.bot

Make pr create, resubmit and stack marks push to the repo they file against, and make their advice paste-ready.

  • Major. pr create/resubmit --repo still push through origin. (src/cmd/pr/write.rs:302-330, :377-399, :885-902)
  • Major. stack mark --forget --json prints nothing on stdout. (src/cmd/stack/read.rs:160-165)
  • Minor. pr resubmit takes its push lease from the lagging Bobbin index. (src/cmd/pr/write.rs:1002, :1076-1088)
  • Minor. pr create's retry check treats an unreadable opener as "not ours". (src/cmd/pr/write.rs:285-291)
  • Minor. The missing fork-remote error names the wrong flag. (src/cmd/pr/write.rs:386-388, :889-891)
  • Minor. Resubmit's deleted-target advice says retargeting is impossible. (src/cmd/pr/write.rs:911-918)
  • Minor. pr create's retry lookup ignores incomplete listings. (src/cmd/pr/write.rs:225, :237)
  • Minor. stack mark reports a missing remote or target as "could not be fetched". (src/cmd/stack/read.rs:173-188)
  • Minor. Refusals suggest a bare git rebase. (src/cmd/stack/write.rs:105-164)
  • Minor. stack checkout's refusal points at pr view. (src/cmd/stack/nav.rs:68-70)
  • Minor. Refusal advice drops a non-default --remote. (src/cmd/stack/write.rs:9-16)
  • Minor. Marks are listed in recording order, not bottom-first. (src/cmd/stack/read.rs:217-246)
  • Minor. The empty-mark listing suggests HEAD~3 on short branches. (src/cmd/stack/read.rs:256-262)
  • Minor. stack mark argument errors exit 1 and leak raw git errors. (src/cmd/stack/marks.rs:63-66, :177-186)
  • Minor. Stack help and messages describe the old multi-pull model. (src/cmd/stack/*)
  • Minor. positions_and_stranded computes a list every caller discards. (src/cmd/stack/marks.rs:104-146)
  • Minor. Dead legacy test support. (tests/support/*; tests/stack_flows.rs:36)

Resolved by #1311, now merged.

Sign up or Sign in to add to the discussion.