atproto git client atgc.codes

1.0: make run logs end cleanly and harden release and string I/O #1305

Closed opened by orbit-nodachi.test.pds.did.bot

Make run logs succeed on a normal stream end, and make release and string commands safe with large inputs and odd names.

  • Blocker. run logs treats every normal stream end as a protocol error and exits 6. (src/clients/tangled/spindle.rs:228)
  • Major. run commands print spindle-supplied id, commit and status without cleaning. (src/cmd/run/mod.rs:276-280, :356-362; src/cmd/run/watch.rs:118; src/cmd/run/write.rs:223)
  • Major. Release help examples and the no-repo hint use tangled.org/core, which fails. (src/cmd/release.rs:29, :125-126)
  • Minor. An unknown --workflow is reported as "could not reach". (src/clients/tangled/spindle.rs:223)
  • Minor. run logs panics on a huge --timeout. (src/clients/tangled/spindle.rs:216)
  • Minor. run trigger shows raw git errors with exit 1. (src/cmd/run/write.rs:333)
  • Minor. run logs --json drops outcome. (src/lexicon/ci.rs:178-189)
  • Minor. run trigger --dry-run --json leaves out ref. (src/cmd/run/write.rs:112-123)
  • Minor. Spindle retry lines are labelled knot. (src/clients/tangled/spindle.rs:315-319)
  • Minor. release download exits 5 with no JSON when the tag has no artifacts. (src/cmd/release.rs:446)
  • Minor. release download --force can delete hidden .tmp. files in the working directory. (src/cmd/release.rs:500; src/config/dir.rs:639)
  • Minor. string create reads all input before the 1 MB check. (src/cmd/string.rs:539)
  • Minor. release view does not encode the tag in its URL. (src/cmd/release.rs:371)
  • Minor. release --repo help leaves out the DID form. (src/cmd/release.rs:63)

Resolved by #1312, now merged.

Sign up or Sign in to add to the discussion.