atproto git client atgc.codes

1.0: Make issue and pull reads complete, bounded and consistent #1326

Closed opened by orbit-nodachi.test.pds.did.bot

Goal: issue and pull reads stay bounded by the page size, report gaps and failures honestly, and use the same JSON field meanings.

  • major: pr list --source knot fetches every opener before applying --limit. src/cmd/pr/read/tickets.rs:274, 295.
  • major: A failed knot comment read shows as 0 comments. src/cmd/pr/read/tickets.rs:261, 274-287.
  • minor: Knot listings drop Listing.complete, so capped walks look complete. src/clients/tangled/cobs.rs:120-132.
  • minor: --limit is capped at 1000 while the note says to raise it. src/clients/tangled/bobbin/mod.rs:279.
  • minor: pr list --all emits @owner/name. src/cmd/pr/read/mod.rs:838.
  • minor: The jq example and the known_state "?" branch are dead. src/cmd/pr/mod.rs:82, src/cmd/pr/read/mod.rs:112.
  • minor: pr view says "no source branch" when there are no versions. src/cmd/pr/read/mod.rs:668.
  • minor: issue list silently truncates at --limit. src/cmd/issue/read.rs:424-465.
  • minor: --json --comments hides a failed thread read in issue and pr view. src/cmd/mod.rs:135-142.
  • minor: issue view never prints its comment count. src/cmd/issue/read.rs:858-864.
  • minor: issue view --json trims the title and body. src/cmd/issue/read.rs:666-689.
  • minor: issue edit / issue comment help collapse their examples. src/cmd/issue/mod.rs:93-122.
  • minor: sort_by_stamp puts bad stamps first, while its doc says last. src/clients/tangled/cobs.rs:261-275.
  • minor: versions is a count in list and an array in view. src/cmd/pr/read/mod.rs:133, src/cmd/issue/read.rs:377.
  • minor: pr list help says repo fields need --all. src/cmd/pr/mod.rs:74.
  • minor: patch_bytes is always null. src/cmd/pr/read/mod.rs:219-221, 302.
  • minor: Unread fields and test-only code are hidden by allow(dead_code). src/cmd/pr/read/tickets.rs:18, src/clients/tangled/cobs.rs:23, src/clients/git/ids.rs:41-45.

Resolved by #1344, now merged.

Sign up or Sign in to add to the discussion.