atproto git client atgc.codes

1.0: Fix release, string and run output and cancellation #1329

Closed opened by orbit-nodachi.test.pds.did.bot

Goal: release, string and run commands show correct, clean output and refuse workflows that do not exist.

  • major: The account column is garbled because the OSC 8 link is cut after wrapping. src/cmd/release.rs:423, src/cmd/pr/read/mod.rs:396-401, src/cmd/issue/read.rs:562-567.
  • major: run cancel accepts a missing workflow and reports it cancelled. src/cmd/run/write.rs:259, 286-291.
  • minor: string view prints raw OSC 8 text. src/cmd/string.rs:503-506.
  • minor: The unmatched-artifact count underflows. src/cmd/release.rs:289-293.
  • minor: The string list view: link points at a missing route. src/cmd/string.rs:332-338.
  • minor: Lightweight tags show no date or message. src/model/release.rs:43-52.
  • minor: release list byte-slices the oid. src/cmd/release.rs:329.
  • minor: release download --force leaves a temp file. src/config/dir.rs:644-650.
  • minor: The run logs connect ignores --connect-timeout and exits 1. src/clients/tangled/spindle.rs:222-240.
  • minor: run watch waits out a blocked pipeline. src/cmd/run/watch.rs:28-81.
  • minor: Spindle notes are tagged Knot. src/cmd/run/mod.rs:242-265, src/cmd/run/logs.rs:56, src/cmd/pr/checks.rs:96-100.
  • minor: A tag push shows as a branch. src/lexicon/ci.rs:123.
  • minor: artifacts is a count in list and an array in view. src/cmd/release.rs:281, 375.

Resolved by #1342, now merged.

Reopening: the garbled account column was fixed only in release view. pr list and issue list still cut the column after the terminal link is added, so the escape sequence gets sliced (src/cmd/pr/read/mod.rs and src/cmd/issue/read.rs). A fix is on the way.

Resolved by #1417, now merged.

Sign up or Sign in to add to the discussion.