tests fr this time :3 #30

Closed

r0chd.pl 4mo ago

targeting master from deleted fork:master

Closed opened by and assigned to

r0chd.pl 4mo ago targeting master from deleted fork:master

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

Commits 0

Could not load commits.

Comments

v0 4mo ago

r0chd.pl 4mo ago

.tangled/workflows/coverage.yaml:65 SECRET_ACCESS_KEY not SECRETS_ACCESS_KEY

r0chd.pl 4mo ago

daemon/src/cgroup.rs:18 Error should probably be propagated and fail at startup.

If cgroup can't be initialized then the session manager cannot be used to properly manage sessions (kill/terminate do nothing) and polkit won't work since we cannot do a pid-to-session lookup.

I'm guessing it could cause even more runtime issues

r0chd.pl 4mo ago

daemon/src/main.rs:185

root should still be able to do that even if management_uid isn't root

parzivale.tngl.sh 4mo ago

I'll update the root thing. Regarding cgroups, I did this namely to allow the test environment to start without access to the filesystem, I could seperate out a path for tests if you like

r0chd.pl 4mo ago

okay I didnt think of that, we could do that instead with dependency injection (god I hate that name) and pass a dummy CgroupManager to the run function instead of it being created inside of it, but that would require making a trait

parzivale.tngl.sh 4mo ago

I like the idea of a dummy CgroupManager I'll implement that

parzivale.tngl.sh 4mo ago

Ok I think this is looking good

r0chd.pl 4mo ago

tangled bug, merged manually ;/

Versions