@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't SIGINT ourselves on bad daemon data
Summary:
If daemon data is mangled, `bin/phd restart` will SIGINT process `0`, which kills it.
uh oh T.T so sad
Test Plan: Used `bin/phd start` to start daemons; removed PID information from one; saw `bin/phd stop` shut down cleanly and not kill itself.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: mholden, epriestley
Differential Revision: https://secure.phabricator.com/D10308
+6
+6
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
+6
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
···
357
357
$pid = $daemon->getPID();
358
358
$name = $daemon->getName();
359
359
360
+
if (!$pid) {
361
+
$console->writeOut("%s\n", pht("Daemon '%s' has no PID!", $name));
362
+
unset($daemons[$key]);
363
+
continue;
364
+
}
365
+
360
366
switch ($signo) {
361
367
case SIGINT:
362
368
$message = pht("Interrupting daemon '%s' (%s)...", $name, $pid);