recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow lint messages to be rendered as Remarkup

Summary: Some linter messages, such as those produced by `ArcanistPHPCompatibilityXHPASTLinterRule`, contain backticks but are currently rendered as Remarkup literals. I think that it is generally desirable to allow lint messages to be rendered as Remarkup, although we should ideally have a way to render Remarkup for use on the command line (I actually think that this already exists, but I don't think that `arc lint` does this when rendering linter messages).

Test Plan: Resubmitted D14481 to my dev install and saw Remarkuped lint messages.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14485

authored by

Joshua Spence and committed by
joshuaspence 1f1c3f40 ca0b36c1

+3 -7
-1
src/applications/differential/controller/DifferentialChangesetViewController.php
··· 387 387 $inlines = array(); 388 388 foreach ($messages as $message) { 389 389 $description = $message->getProperty('description'); 390 - $description = '%%%'.$description.'%%%'; 391 390 392 391 $inlines[] = id(clone $template) 393 392 ->setSyntheticAuthor(pht('Lint: %s', $message->getName()))
+3 -6
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
··· 227 227 228 228 $action_buttons = array(); 229 229 if ($this->allowReply) { 230 - 231 230 if (!$is_synthetic) { 232 - 233 231 // NOTE: No product reason why you can't reply to these, but the reply 234 232 // mechanism currently sends the inline comment ID to the server, not 235 233 // file/line information, and synthetic comments don't have an inline ··· 242 240 ->addSigil('differential-inline-reply') 243 241 ->setMustCapture(true); 244 242 } 245 - 246 243 } 247 244 } 248 245 ··· 267 264 $links[] = javelin_tag( 268 265 'a', 269 266 array( 270 - 'class' => 'inline-button-divider pml msl', 271 - 'meta' => array( 267 + 'class' => 'inline-button-divider pml msl', 268 + 'meta' => array( 272 269 'anchor' => $anchor_name, 273 270 ), 274 - 'sigil' => 'differential-inline-preview-jump', 271 + 'sigil' => 'differential-inline-preview-jump', 275 272 ), 276 273 pht('Not Visible')); 277 274