recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Give Phriction documents a normal timeline

Summary:
Ref T13077. See PHI840. Ref T1894. I'm planning to just let you comment on Phriction documents. I think this will create a few problems (e.g., around popular documents which collect long comment threads that are eventually obsolete) but nothing should be too terribly critical (e.g., we handle it gracefully when objects have very large number of comments/transactions) and for most documents this is likely just a net improvement.

"Just enable comments" is probably not the final iteration on this, but I think it's probably a step forward on the balance, not a step sideways or a slippery slope down into a dark hole or anything.

Test Plan: {F5877316}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13077, T1894

Differential Revision: https://secure.phabricator.com/D19659

epriestley 2379c21f 185e72c8

+14 -2
+14 -2
src/applications/phriction/controller/PhrictionDocumentController.php
··· 348 348 $page_content->setCurtain($curtain); 349 349 } 350 350 351 + $timeline = $this->buildTransactionTimeline( 352 + $document, 353 + new PhrictionTransactionQuery()); 354 + 351 355 return $this->newPage() 352 356 ->setTitle($page_title) 353 357 ->setCrumbs($crumbs) ··· 356 360 array( 357 361 $page_content, 358 362 $prop_list, 359 - $children, 363 + phutil_tag( 364 + 'div', 365 + array( 366 + 'class' => 'phui-document-view-pro-box', 367 + ), 368 + array( 369 + $children, 370 + $timeline, 371 + )), 360 372 )); 361 373 362 374 } ··· 600 612 ), 601 613 $list))); 602 614 603 - return phutil_tag_div('phui-document-view-pro-box', $box); 615 + return $box; 604 616 } 605 617 606 618 private function renderChildDocumentLink(array $info) {