recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages

Summary:
Since PHP 8.1, passing a null string to `ltrim(string $string, string $characters)` is deprecated.

Thus do not check for `$path = null` but check for `$path = ''` before passing `$path` as the `$string` parameter to `ltrim()`, like src/applications/settings/panel/PhabricatorSettingsPanel.php already does.

Closes T15359

Test Plan: Applied this change (on top of D25197) and five applications' Configure pages (Differential, Maniphest, Files, Paste, and Ponder) finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15359

Differential Revision: https://we.phorge.it/D25198

Andre Klapper 3819f7ff d74e9d82

+7 -1
+7 -1
src/applications/meta/panel/PhabricatorApplicationConfigurationPanel.php
··· 24 24 return $this->application; 25 25 } 26 26 27 - public function getPanelURI($path = null) { 27 + /** 28 + * Get the URI for this application configuration panel. 29 + * 30 + * @param string? Optional path to append. 31 + * @return string Relative URI for the panel. 32 + */ 33 + public function getPanelURI($path = '') { 28 34 $app_key = get_class($this->getApplication()); 29 35 $panel_key = $this->getPanelKey(); 30 36 $base = "/applications/panel/{$app_key}/{$panel_key}/";