@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide curtainview on mobile if it's empty
Summary: If we don't have any panels, just an action list, we want to hide the entire box on mobile since it's just an empty line.
Test Plan: Review Owners, Differential curtains on mobile, desktop.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18350
+15
-4
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => 'cc0772c6',
12
+
'core.pkg.css' => '04da74af',
13
13
'core.pkg.js' => '5d80e0db',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
···
149
149
'rsrc/css/phui/phui-comment-form.css' => 'ac68149f',
150
150
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
151
151
'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
152
-
'rsrc/css/phui/phui-curtain-view.css' => '55dd0e59',
152
+
'rsrc/css/phui/phui-curtain-view.css' => 'ca363f15',
153
153
'rsrc/css/phui/phui-document-pro.css' => '8af7ea27',
154
154
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
155
155
'rsrc/css/phui/phui-document.css' => 'c32e8dec',
···
835
835
'phui-comment-form-css' => 'ac68149f',
836
836
'phui-comment-panel-css' => 'f50152ad',
837
837
'phui-crumbs-view-css' => '6ece3bbb',
838
-
'phui-curtain-view-css' => '55dd0e59',
838
+
'phui-curtain-view-css' => 'ca363f15',
839
839
'phui-document-summary-view-css' => '9ca48bdf',
840
840
'phui-document-view-css' => 'c32e8dec',
841
841
'phui-document-view-pro-css' => '8af7ea27',
+8
-1
src/view/layout/PHUICurtainView.php
+8
-1
src/view/layout/PHUICurtainView.php
···
46
46
47
47
$panels = $this->renderPanels();
48
48
49
-
return id(new PHUIObjectBoxView())
49
+
$box = id(new PHUIObjectBoxView())
50
50
->appendChild($action_list)
51
51
->appendChild($panels)
52
52
->addClass('phui-two-column-properties');
53
+
54
+
// We want to hide this UI on mobile if there are no child panels
55
+
if (!$panels) {
56
+
$box->addClass('curtain-no-panels');
57
+
}
58
+
59
+
return $box;
53
60
}
54
61
55
62
private function renderPanels() {