@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove PhabricatorUser->loadPreferences()
Summary: Ref T4103. This method has no more callers.
Test Plan: `grep`
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T4103
Differential Revision: https://secure.phabricator.com/D16039
-33
-23
src/applications/people/storage/PhabricatorUser.php
-23
src/applications/people/storage/PhabricatorUser.php
···
568
568
return $this->getUserSetting(PhabricatorPronounSetting::SETTINGKEY);
569
569
}
570
570
571
-
public function loadPreferences() {
572
-
if ($this->preferences) {
573
-
return $this->preferences;
574
-
}
575
-
576
-
$preferences = null;
577
-
if ($this->getPHID()) {
578
-
$preferences = id(new PhabricatorUserPreferencesQuery())
579
-
->setViewer($this)
580
-
->withUsers(array($this))
581
-
->executeOne();
582
-
}
583
-
584
-
if (!$preferences) {
585
-
$preferences = new PhabricatorUserPreferences();
586
-
$preferences->setUserPHID($this->getPHID());
587
-
$preferences->attachUser($this);
588
-
}
589
-
590
-
$this->preferences = $preferences;
591
-
return $preferences;
592
-
}
593
-
594
571
public function loadEditorLink(
595
572
$path,
596
573
$line,
-10
src/applications/settings/storage/PhabricatorUserPreferences.php
-10
src/applications/settings/storage/PhabricatorUserPreferences.php
···
98
98
return false;
99
99
}
100
100
101
-
// TODO: Remove this once all edits go through the Editor. For now, some
102
-
// old edits just do direct saves so make sure we nuke the cache.
103
-
public function save() {
104
-
PhabricatorUserCache::clearCache(
105
-
PhabricatorUserPreferencesCacheType::KEY_PREFERENCES,
106
-
$this->getUserPHID());
107
-
108
-
return parent::save();
109
-
}
110
-
111
101
/**
112
102
* Load or create a preferences object for the given user.
113
103
*