recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace a few null return values with void for consistency

Summary: These private functions are not supposed to return anything as their return value is never read anyway, thus consistently return void instead of null (which makes no technical difference but is easier to read).

Test Plan: Look at the other return values in the same function, and the calls of the function.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26666

Andre Klapper a0e2332c e2b1c69f

+8 -5
+3
src/applications/differential/parser/DifferentialChangesetParser.php
··· 366 366 return $this; 367 367 } 368 368 369 + /** 370 + * @return bool 371 + */ 369 372 private function loadCache() { 370 373 $render_cache_key = $this->getRenderCacheKey(); 371 374 if (!$render_cache_key) {
+1 -1
src/applications/drydock/worker/DrydockLeaseUpdateWorker.php
··· 279 279 280 280 $phids = $lease->getAllocatedResourcePHIDs(); 281 281 if (!$phids) { 282 - return null; 282 + return; 283 283 } 284 284 285 285 $resources = id(new DrydockResourceQuery())
+1 -1
src/applications/flag/events/PhabricatorFlagsUIEventListener.php
··· 29 29 } 30 30 31 31 if (!$this->canUseApplication($event->getUser())) { 32 - return null; 32 + return; 33 33 } 34 34 35 35 $flag = PhabricatorFlagQuery::loadUserFlag($user, $object->getPHID());
+2 -2
src/applications/tokens/event/PhabricatorTokenUIEventListener.php
··· 42 42 } 43 43 44 44 if (!$this->canUseApplication($event->getUser())) { 45 - return null; 45 + return; 46 46 } 47 47 48 48 $can_interact = PhabricatorPolicyFilter::canInteract($user, $object); ··· 93 93 } 94 94 95 95 if (!$this->canUseApplication($event->getUser())) { 96 - return null; 96 + return; 97 97 } 98 98 99 99 $tokens_given = id(new PhabricatorTokenGivenQuery())
+1 -1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 4963 4963 ->withProxyPHIDs($removed_phids) 4964 4964 ->execute(); 4965 4965 if (!$proxy_columns) { 4966 - return array(); 4966 + return; 4967 4967 } 4968 4968 4969 4969 $proxy_phids = mpull($proxy_columns, 'getPHID');