recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When Points are disabled, replace "Point Limit" with "Count Limit" label

Summary:
When Maniphest points are disabled (the default) we have some labels talking about "Point Limit" but they are really working like a "Count Limit",
so we update the labels accordingly.

After this change, when the option maniphest.points is enabled:

- everything remains as-is

After this change, When that option is disabled (the default):

- labels about count limit, are "Count Limit"

We just avoid confusion with what really happens.

This task is NOT about changing the backend or changing behavior.

| Before | After |
|------------|------------|
| {F5082231} | {F5082234} |
| {F5083540} | {F5083543} |

Closes T16104

Test Plan:
Check the configuration page /config/edit/maniphest.points/ - have it empty (no points):

- visit a workboard column and click edit: - you see "Count Limit" (no more Point Limit)
- visit the page /project/board/1/column/1/ - you see "Count Limit" (no more Point Limit)

To check for regressions, toggle the configuration /config/edit/maniphest.points/ to activate points:

- visit a workboard column and click edit: - you see "Point Limit"
- visit the page /project/board/1/column/1/ - you see "Point Limit"

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T16104

Differential Revision: https://we.phorge.it/D26078

Valerio Bozzolan a22fe117 98dd2dfb

+23 -4
+10 -1
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
··· 100 100 } else { 101 101 $limit_text = $limit; 102 102 } 103 - $properties->addProperty(pht('Point Limit'), $limit_text); 103 + 104 + // The "limit" has always had a dual purpose. 105 + // Let's make it more obvious. 106 + if (ManiphestTaskPoints::getIsEnabled()) { 107 + $limit_label = pht('Point Limit'); 108 + } else { 109 + $limit_label = pht('Count Limit'); 110 + } 111 + 112 + $properties->addProperty($limit_label, $limit_text); 104 113 105 114 $box = id(new PHUIObjectBoxView()) 106 115 ->setHeaderText(pht('Details'))
+13 -3
src/applications/project/controller/PhabricatorProjectColumnEditController.php
··· 167 167 ->setError($e_milestone_name)); 168 168 } 169 169 170 + // The "limit" has always had a dual purpose. 171 + // Let's make it more obvious. 172 + if (ManiphestTaskPoints::getIsEnabled()) { 173 + $limit_label = pht('Point Limit'); 174 + $limit_caption = 175 + pht('Maximum number of points of tasks allowed in the column.'); 176 + } else { 177 + $limit_label = pht('Count Limit'); 178 + $limit_caption = pht('Maximum number of tasks allowed in the column.'); 179 + } 180 + 170 181 $form->appendChild( 171 182 id(new AphrontFormTextControl()) 172 183 ->setValue($v_limit) 173 - ->setLabel(pht('Point Limit')) 184 + ->setLabel($limit_label) 174 185 ->setName('limit') 175 186 ->setError($e_limit) 176 - ->setCaption( 177 - pht('Maximum number of points of tasks allowed in the column.'))); 187 + ->setCaption($limit_caption)); 178 188 179 189 if ($is_new) { 180 190 $title = pht('Create Column');