@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Redesign Diviner

Summary:
This implements `PHUIDocumentViewPro` which should move to be the base for all documents (Phame, Phriction, Legalpad, Diviner). Overall this feels really good to me, but I'd like to roll it out into Diviner specifically first to work through the issues and then move into other apps and drop `PHUIDocumentView` once everything is converted. Some features are:

- White Background, no border on page
- Table of Contents is move to hidden menu (more space for documentation)
- Property List sits under the document

Some design decisions above are in anticipation of Phriction v3 and Unbeta Phame, specifically commenting and maybe some cool new Remarkup text layout options for Phame.

Test Plan:
Went through tons of pages on Diviner on Desktop, Tablet, Mobile. Bounce back to Phriction to make sure DocumentView CSS changes actually look better there.

{F930518}

{F930519}

{F930520}

{F930521}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: tycho.tatitscheff, joshuaspence, Korvin

Differential Revision: https://secure.phabricator.com/D14374

+338 -88
+13 -11
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '15e557bc', 10 + 'core.pkg.css' => 'a56d7104', 11 11 'core.pkg.js' => '47dc9ebb', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', ··· 103 103 'rsrc/css/application/slowvote/slowvote.css' => '475b4bd2', 104 104 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 105 105 'rsrc/css/application/uiexample/example.css' => '528b19de', 106 - 'rsrc/css/core/core.css' => 'a76cefc9', 107 - 'rsrc/css/core/remarkup.css' => '8d341238', 106 + 'rsrc/css/core/core.css' => '78e8d7ea', 107 + 'rsrc/css/core/remarkup.css' => 'f18999d1', 108 108 'rsrc/css/core/syntax.css' => '9fd11da8', 109 109 'rsrc/css/core/z-index.css' => '57ddcaa2', 110 - 'rsrc/css/diviner/diviner-shared.css' => '5a337049', 110 + 'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa', 111 111 'rsrc/css/font/font-awesome.css' => 'd2fc4e8d', 112 112 'rsrc/css/font/font-lato.css' => '5ab1a46a', 113 113 'rsrc/css/font/font-roboto-slab.css' => 'f24a53cb', ··· 126 126 'rsrc/css/phui/phui-box.css' => 'a5bb366d', 127 127 'rsrc/css/phui/phui-button.css' => '16020a60', 128 128 'rsrc/css/phui/phui-crumbs-view.css' => 'd842f867', 129 - 'rsrc/css/phui/phui-document.css' => '0267054b', 129 + 'rsrc/css/phui/phui-document-pro.css' => '3657eb4b', 130 + 'rsrc/css/phui/phui-document.css' => '78521ba3', 130 131 'rsrc/css/phui/phui-feed-story.css' => 'b7b26d23', 131 - 'rsrc/css/phui/phui-fontkit.css' => 'cb8ae7ad', 132 + 'rsrc/css/phui/phui-fontkit.css' => '7837a28c', 132 133 'rsrc/css/phui/phui-form-view.css' => '621b21c5', 133 134 'rsrc/css/phui/phui-form.css' => 'afdb2c6e', 134 135 'rsrc/css/phui/phui-header-view.css' => '55bb32dd', ··· 523 524 'diffusion-icons-css' => '2941baf1', 524 525 'diffusion-readme-css' => '2106ea08', 525 526 'diffusion-source-css' => '075ba788', 526 - 'diviner-shared-css' => '5a337049', 527 + 'diviner-shared-css' => 'aa3656aa', 527 528 'font-fontawesome' => 'd2fc4e8d', 528 529 'font-lato' => '5ab1a46a', 529 530 'font-roboto-slab' => 'f24a53cb', ··· 713 714 'phabricator-busy' => '59a7976a', 714 715 'phabricator-chatlog-css' => 'd295b020', 715 716 'phabricator-content-source-view-css' => '4b8b05d4', 716 - 'phabricator-core-css' => 'a76cefc9', 717 + 'phabricator-core-css' => '78e8d7ea', 717 718 'phabricator-countdown-css' => 'e7544472', 718 719 'phabricator-dashboard-css' => 'eb458607', 719 720 'phabricator-drag-and-drop-file-upload' => 'ad10aeac', ··· 735 736 'phabricator-object-selector-css' => '85ee8ce6', 736 737 'phabricator-phtize' => 'd254d646', 737 738 'phabricator-prefab' => '6920d200', 738 - 'phabricator-remarkup-css' => '8d341238', 739 + 'phabricator-remarkup-css' => 'f18999d1', 739 740 'phabricator-search-results-css' => '7dea472c', 740 741 'phabricator-shaped-request' => '7cbe244b', 741 742 'phabricator-side-menu-view-css' => 'bec2458e', ··· 775 776 'phui-calendar-list-css' => 'c1c7f338', 776 777 'phui-calendar-month-css' => '476be7e0', 777 778 'phui-crumbs-view-css' => 'd842f867', 778 - 'phui-document-view-css' => '0267054b', 779 + 'phui-document-view-css' => '78521ba3', 780 + 'phui-document-view-pro-css' => '3657eb4b', 779 781 'phui-feed-story-css' => 'b7b26d23', 780 782 'phui-font-icon-base-css' => 'ecbbb4c2', 781 - 'phui-fontkit-css' => 'cb8ae7ad', 783 + 'phui-fontkit-css' => '7837a28c', 782 784 'phui-form-css' => 'afdb2c6e', 783 785 'phui-form-view-css' => '621b21c5', 784 786 'phui-header-view-css' => '55bb32dd',
+2
src/__phutil_library_map__.php
··· 1433 1433 'PHUIDiffTwoUpInlineCommentRowScaffold' => 'infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php', 1434 1434 'PHUIDocumentExample' => 'applications/uiexample/examples/PHUIDocumentExample.php', 1435 1435 'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php', 1436 + 'PHUIDocumentViewPro' => 'view/phui/PHUIDocumentViewPro.php', 1436 1437 'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php', 1437 1438 'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php', 1438 1439 'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php', ··· 5338 5339 'PHUIDiffTwoUpInlineCommentRowScaffold' => 'PHUIDiffInlineCommentRowScaffold', 5339 5340 'PHUIDocumentExample' => 'PhabricatorUIExample', 5340 5341 'PHUIDocumentView' => 'AphrontTagView', 5342 + 'PHUIDocumentViewPro' => 'AphrontTagView', 5341 5343 'PHUIFeedStoryExample' => 'PhabricatorUIExample', 5342 5344 'PHUIFeedStoryView' => 'AphrontView', 5343 5345 'PHUIFormDividerControl' => 'AphrontFormControl',
+4
src/applications/base/controller/PhabricatorController.php
··· 334 334 } 335 335 } 336 336 337 + if (idx($options, 'class')) { 338 + $page->addClass($options['class']); 339 + } 340 + 337 341 if (!($view instanceof AphrontSideNavFilterView)) { 338 342 $nav = new AphrontSideNavFilterView(); 339 343 $nav->appendChild($view);
+7 -18
src/applications/diviner/controller/DivinerAtomController.php
··· 58 58 $crumbs->addTextCrumb($atom_short_title); 59 59 60 60 $header = id(new PHUIHeaderView()) 61 - ->setHeader($this->renderFullSignature($symbol)) 62 - ->addTag( 63 - id(new PHUITagView()) 64 - ->setType(PHUITagView::TYPE_STATE) 65 - ->setBackgroundColor(PHUITagView::COLOR_BLUE) 66 - ->setName(DivinerAtom::getAtomTypeNameString( 67 - $atom ? $atom->getType() : $symbol->getType()))); 61 + ->setHeader($this->renderFullSignature($symbol)); 68 62 69 63 $properties = new PHUIPropertyListView(); 70 64 ··· 78 72 $prop_list = new PHUIPropertyGroupView(); 79 73 $prop_list->addPropertyList($properties); 80 74 81 - $document = id(new PHUIDocumentView()) 75 + $document = id(new PHUIDocumentViewPro()) 82 76 ->setBook($book->getTitle(), $group_name) 83 77 ->setHeader($header) 84 78 ->addClass('diviner-view') 85 - ->appendChild($prop_list); 79 + ->setPropertyList($prop_list); 86 80 87 81 if ($atom) { 88 82 $this->buildDefined($properties, $symbol); ··· 163 157 ->setHeader($spec['title'])); 164 158 165 159 $task_methods = idx($methods_by_task, $spec['name'], array()); 166 - $inner_box = id(new PHUIBoxView()) 167 - ->addPadding(PHUI::PADDING_LARGE_LEFT) 168 - ->addPadding(PHUI::PADDING_LARGE_RIGHT) 169 - ->addPadding(PHUI::PADDING_LARGE_BOTTOM); 170 160 171 161 $box_content = array(); 172 162 if ($task_methods) { ··· 198 188 $box_content = phutil_tag('em', array(), $no_methods); 199 189 } 200 190 201 - $inner_box->appendChild($box_content); 191 + $inner_box = phutil_tag_div('diviner-task-items', $box_content); 202 192 $section->addContent($inner_box); 203 193 } 204 194 $document->appendChild($section); ··· 246 236 ->setHref('#'.$key)); 247 237 } 248 238 249 - $document->setSideNav($side, PHUIDocumentView::NAV_TOP); 239 + $document->setToc($side); 250 240 } 251 241 252 242 return $this->buildApplicationPage( ··· 256 246 ), 257 247 array( 258 248 'title' => $symbol->getTitle(), 249 + 'class' => 'pro-white-background', 259 250 )); 260 251 } 261 252 ··· 629 620 $content = phutil_tag( 630 621 'div', 631 622 array( 632 - 'class' => 'phabricator-remarkup', 623 + 'class' => 'phabricator-remarkup diviner-remarkup-section', 633 624 ), 634 625 $content); 635 626 } else { ··· 668 659 669 660 if (($impl !== $parent) || $out) { 670 661 $where = id(new PHUIBoxView()) 671 - ->addPadding(PHUI::PADDING_MEDIUM_LEFT) 672 - ->addPadding(PHUI::PADDING_MEDIUM_RIGHT) 673 662 ->addClass('diviner-method-implementation-header') 674 663 ->appendChild($impl->getName()); 675 664 $doc = array($where, $doc);
+2 -1
src/applications/diviner/controller/DivinerBookController.php
··· 53 53 ->setName($book->getRepository()->getMonogram())); 54 54 } 55 55 56 - $document = new PHUIDocumentView(); 56 + $document = new PHUIDocumentViewPro(); 57 57 $document->setHeader($header); 58 58 $document->addClass('diviner-view'); 59 59 ··· 111 111 ), 112 112 array( 113 113 'title' => $book->getTitle(), 114 + 'class' => 'pro-white-background', 114 115 )); 115 116 } 116 117
+3 -6
src/applications/diviner/controller/DivinerMainController.php
··· 30 30 ->setHeader(pht('Documentation Books')) 31 31 ->addActionLink($query_button); 32 32 33 - $document = new PHUIDocumentView(); 33 + $document = new PHUIDocumentViewPro(); 34 34 $document->setHeader($header); 35 35 $document->addClass('diviner-view'); 36 36 ··· 45 45 $list[] = $item; 46 46 } 47 47 $list = id(new PHUIBoxView()) 48 - ->addPadding(PHUI::PADDING_LARGE_LEFT) 49 - ->addPadding(PHUI::PADDING_LARGE_RIGHT) 50 - ->addPadding(PHUI::PADDING_SMALL_TOP) 51 - ->addPadding(PHUI::PADDING_SMALL_BOTTOM) 48 + ->addPadding(PHUI::PADDING_MEDIUM_TOP) 52 49 ->appendChild($list); 53 50 54 51 $document->appendChild($list); ··· 82 79 ), 83 80 array( 84 81 'title' => pht('Documentation Books'), 85 - 'fonts' => true, 82 + 'class' => 'pro-white-background', 86 83 )); 87 84 } 88 85 }
+2 -4
src/applications/diviner/view/DivinerSectionView.php
··· 30 30 31 31 $header = id(new PHUIHeaderView()) 32 32 ->setBleedHeader(true) 33 + ->addClass('diviner-section-header') 33 34 ->setHeader($this->header); 34 35 35 - $content = id(new PHUIBoxView()) 36 - ->addPadding(PHUI::PADDING_LARGE_LEFT) 37 - ->addPadding(PHUI::PADDING_LARGE_RIGHT) 38 - ->appendChild($this->content); 36 + $content = phutil_tag_div('diviner-section-content', $this->content); 39 37 40 38 return array($header, $content); 41 39 }
+9 -1
src/view/page/PhabricatorStandardPageView.php
··· 11 11 private $glyph; 12 12 private $menuContent; 13 13 private $showChrome = true; 14 + private $classes = array(); 14 15 private $disableConsole; 15 16 private $pageObjects = array(); 16 17 private $applicationMenu; ··· 65 66 66 67 public function getShowChrome() { 67 68 return $this->showChrome; 69 + } 70 + 71 + public function addClass($class) { 72 + $this->classes[] = $class; 73 + return $this; 68 74 } 69 75 70 76 public function appendPageObjects(array $objs) { ··· 511 517 } 512 518 513 519 $classes[] = 'phui-theme-'.PhabricatorEnv::getEnvConfig('ui.header-color'); 514 - 520 + foreach ($this->classes as $class) { 521 + $classes[] = $class; 522 + } 515 523 516 524 return implode(' ', $classes); 517 525 }
+136
src/view/phui/PHUIDocumentViewPro.php
··· 1 + <?php 2 + 3 + final class PHUIDocumentViewPro extends AphrontTagView { 4 + 5 + private $header; 6 + private $bookname; 7 + private $bookdescription; 8 + private $fluid; 9 + private $propertyList; 10 + private $toc; 11 + 12 + public function setHeader(PHUIHeaderView $header) { 13 + $header->setTall(true); 14 + $this->header = $header; 15 + return $this; 16 + } 17 + 18 + public function setBook($name, $description) { 19 + $this->bookname = $name; 20 + $this->bookdescription = $description; 21 + return $this; 22 + } 23 + 24 + public function setFluid($fluid) { 25 + $this->fluid = $fluid; 26 + return $this; 27 + } 28 + 29 + public function setPropertyList($view) { 30 + $this->propertyList = $view; 31 + return $this; 32 + } 33 + 34 + public function setToc(PHUIListView $toc) { 35 + $this->toc = $toc; 36 + return $this; 37 + } 38 + 39 + protected function getTagAttributes() { 40 + $classes = array(); 41 + 42 + if ($this->fluid) { 43 + $classes[] = 'phui-document-fluid'; 44 + } 45 + 46 + return array( 47 + 'class' => $classes, 48 + ); 49 + } 50 + 51 + protected function getTagContent() { 52 + require_celerity_resource('phui-document-view-css'); 53 + require_celerity_resource('phui-document-view-pro-css'); 54 + Javelin::initBehavior('phabricator-reveal-content'); 55 + 56 + $classes = array(); 57 + $classes[] = 'phui-document-view'; 58 + $classes[] = 'phui-document-view-pro'; 59 + 60 + $book = null; 61 + if ($this->bookname) { 62 + $book = pht('%s (%s)', $this->bookname, $this->bookdescription); 63 + } 64 + 65 + $main_content = $this->renderChildren(); 66 + 67 + if ($book) { 68 + $this->header->setSubheader($book); 69 + } 70 + 71 + $table_of_contents = null; 72 + if ($this->toc) { 73 + $toc = array(); 74 + $toc_id = celerity_generate_unique_node_id(); 75 + $toc[] = id(new PHUIButtonView()) 76 + ->setTag('a') 77 + ->setIconFont('fa-align-left') 78 + ->setColor(PHUIButtonView::SIMPLE) 79 + ->addClass('phui-document-toc') 80 + ->addSigil('jx-toggle-class') 81 + ->setMetaData(array( 82 + 'map' => array( 83 + $toc_id => 'phui-document-toc-open', 84 + ), 85 + )); 86 + 87 + $toc[] = phutil_tag( 88 + 'div', 89 + array( 90 + 'class' => 'phui-list-sidenav phui-document-toc-list', 91 + ), 92 + $this->toc); 93 + 94 + $table_of_contents = phutil_tag( 95 + 'div', 96 + array( 97 + 'class' => 'phui-document-toc-container', 98 + 'id' => $toc_id, 99 + ), 100 + $toc); 101 + } 102 + 103 + $content_inner = phutil_tag( 104 + 'div', 105 + array( 106 + 'class' => 'phui-document-inner', 107 + ), 108 + array( 109 + $table_of_contents, 110 + $this->header, 111 + $main_content, 112 + )); 113 + 114 + $content = phutil_tag( 115 + 'div', 116 + array( 117 + 'class' => 'phui-document-content', 118 + ), 119 + $content_inner); 120 + 121 + $view = phutil_tag( 122 + 'div', 123 + array( 124 + 'class' => implode(' ', $classes), 125 + ), 126 + $content); 127 + 128 + $list = null; 129 + if ($this->propertyList) { 130 + $list = phutil_tag_div('phui-document-properties', $this->propertyList); 131 + } 132 + 133 + return array($view, $list); 134 + } 135 + 136 + }
+4
webroot/rsrc/css/core/core.css
··· 173 173 height: 2px; 174 174 background: {$sky}; 175 175 } 176 + 177 + html body.pro-white-background { 178 + background-color: white; 179 + }
+3 -26
webroot/rsrc/css/core/remarkup.css
··· 363 363 padding-top: 0; 364 364 } 365 365 366 - body .phabricator-remarkup p:first-child, 367 - body .phabricator-remarkup ul.remarkup-list:first-child, 368 - body .phabricator-remarkup ol.remarkup-list:first-child, 369 - body .phabricator-remarkup .remarkup-code-block:first-child, 370 - body .phabricator-remarkup h1.remarkup-header:first-child, 371 - body .phabricator-remarkup h2.remarkup-header:first-child, 372 - body .phabricator-remarkup h3.remarkup-header:first-child, 373 - body .phabricator-remarkup h4.remarkup-header:first-child, 374 - body .phabricator-remarkup h5.remarkup-header:first-child, 375 - body .phabricator-remarkup h6.remarkup-header:first-child, 376 - body .phabricator-remarkup blockquote:first-child, 377 - body .phabricator-remarkup table.remarkup-table:first-child, 378 - body .phabricator-remarkup .remarkup-note:first-child { 366 + body .phabricator-remarkup *:first-child, 367 + body .phabricator-remarkup .remarkup-header + * { 379 368 margin-top: 0; 380 369 } 381 370 382 - body .phabricator-remarkup p:last-child, 383 - body .phabricator-remarkup ul.remarkup-list:last-child, 384 - body .phabricator-remarkup ol.remarkup-list:last-child, 385 - body .phabricator-remarkup .remarkup-code-block:last-child, 386 - body .phabricator-remarkup h1.remarkup-header:last-child, 387 - body .phabricator-remarkup h2.remarkup-header:last-child, 388 - body .phabricator-remarkup h3.remarkup-header:last-child, 389 - body .phabricator-remarkup h4.remarkup-header:last-child, 390 - body .phabricator-remarkup h5.remarkup-header:last-child, 391 - body .phabricator-remarkup h6.remarkup-header:last-child, 392 - body .phabricator-remarkup blockquote:last-child, 393 - body .phabricator-remarkup table.remarkup-table:last-child, 394 - body .phabricator-remarkup .remarkup-note:last-child { 371 + body .phabricator-remarkup *:last-child { 395 372 margin-bottom: 0; 396 373 } 397 374
+42 -16
webroot/rsrc/css/diviner/diviner-shared.css
··· 8 8 } 9 9 10 10 .diviner-table-view { 11 - margin: 0 16px 24px; 11 + margin: 0 0 24px; 12 12 } 13 13 14 14 .device-phone .diviner-table-view { ··· 65 65 padding: 0 8px 16px 0; 66 66 } 67 67 68 - body .diviner-document-section .phui-header-header { 69 - width: 100%; 68 + .phui-header-shell.diviner-section-header .phui-header-header { 69 + color: #000; 70 70 font-size: 20px; 71 - font-weight: bold; 72 - margin: 0; 73 - padding: 0; 71 + } 72 + 73 + body .diviner-view .diviner-document-section 74 + .phui-header-shell.diviner-section-header { 75 + padding: 0 24px 8px 0; 76 + border-bottom: 1px solid {$thinblueborder}; 77 + margin: 32px 0 16px; 74 78 } 75 79 76 80 body .diviner-document-section .phui-header-shell.phui-bleed-header { 77 - padding: 0; 81 + padding: 16px 0 0 0; 82 + border-bottom: none; 78 83 } 79 84 80 - .phui-property-list-view + .diviner-document-section { 81 - margin-top: -1px; 85 + body .diviner-view .diviner-section-content .phui-header-shell { 86 + margin: 24px 0 8px; 87 + padding: 0; 88 + border: none; 82 89 } 83 90 84 91 .diviner-message-not-documented { 85 92 color: {$lightgreytext}; 86 93 font-style: italic; 87 - margin: 16px; 94 + margin: 12px 0 32px; 95 + font-size: {$biggerfontsize}; 88 96 } 89 97 90 - .diviner-atom-signature { 91 - font-weight: normal; 98 + .diviner-document-section .diviner-message-not-documented { 99 + margin-left: 0; 100 + margin-right: 0; 101 + } 102 + 103 + .phui-document-content .phabricator-remarkup.diviner-remarkup-section { 104 + padding: 16px 0 32px 0; 92 105 } 93 106 94 107 .diviner-atom-signature-name { 95 108 font-weight: bold; 109 + color: {$violet}; 96 110 } 97 111 98 - .diviner-list .diviner-atom-signature { 112 + .diviner-atom-signature { 113 + font-weight: normal; 114 + color: #000; 115 + } 116 + 117 + .phui-header-view .phui-header-header a.diviner-atom-signature-name { 99 118 color: {$violet}; 119 + } 120 + 121 + .phui-header-view .phui-header-header a.diviner-atom-signature-name:hover { 122 + text-decoration: underline !important; 123 + } 124 + 125 + .diviner-list .diviner-atom-signature { 100 126 margin-left: -16px; 101 127 } 102 128 ··· 126 152 } 127 153 128 154 .diviner-list { 129 - padding-left: 12px; 155 + padding-left: 17px; 130 156 } 131 157 132 158 .diviner-list li { ··· 150 176 text-decoration: none; 151 177 } 152 178 153 - .device-desktop .diviner-book-item:hover { 154 - background-color: #F5EEFF; 179 + .device-desktop .diviner-book-item:hover .diviner-book-item-title { 180 + color: {$violet}; 155 181 } 156 182 157 183 .diviner-book-item-title {
+108
webroot/rsrc/css/phui/phui-document-pro.css
··· 1 + /** 2 + * @provides phui-document-view-pro-css 3 + */ 4 + 5 + .phui-document-view.phui-document-view-pro { 6 + max-width: 800px; 7 + padding: 0 16px; 8 + position: relative; 9 + margin: 16px auto; 10 + } 11 + 12 + .phui-document-properties { 13 + max-width: 800px; 14 + padding: 0 16px; 15 + background-color: {$lightgreybackground}; 16 + margin: 0 auto; 17 + border-radius: 3px; 18 + } 19 + 20 + .device-phone .phui-document-properties { 21 + margin: 0 8px; 22 + } 23 + 24 + .device-phone .phui-document-view.phui-document-view-pro { 25 + padding: 0 8px; 26 + margin: 0 auto; 27 + } 28 + 29 + .phui-document-view-pro .phui-document-toc { 30 + position: absolute; 31 + top: 18px; 32 + left: -36px; 33 + } 34 + 35 + a.button.phui-document-toc { 36 + display: inline-block; 37 + height: 16px; 38 + width: 16px; 39 + padding: 3px 8px 4px 8px; 40 + } 41 + 42 + .phui-document-view-pro .phui-document-toc-list { 43 + margin: 8px; 44 + border: 1px solid {$blueborder}; 45 + border-radius: 3px; 46 + box-shadow: {$dropshadow}; 47 + width: 200px; 48 + position: absolute; 49 + z-index: 30; 50 + background-color: #fff; 51 + top: 38px; 52 + left: -44px; 53 + } 54 + 55 + .device .phui-document-view-pro .phui-document-toc { 56 + display: none; 57 + } 58 + 59 + .phui-document-toc-list { 60 + display: none; 61 + } 62 + 63 + .phui-document-toc-open .phui-document-toc-list { 64 + display: block; 65 + } 66 + 67 + .phui-document-toc-open .phui-document-toc { 68 + background-color: {$blue}; 69 + } 70 + 71 + .phui-document-toc-open .phui-document-toc .phui-icon-view { 72 + color: #fff; 73 + } 74 + 75 + .phui-document-view-pro .phui-document-content .phabricator-remarkup { 76 + padding: 16px 0; 77 + line-height: 1.7em; 78 + } 79 + 80 + .device-desktop .phui-document-view.phui-document-view-pro { 81 + border: 0; 82 + } 83 + 84 + .phui-document-view.phui-document-view-pro .phui-header-shell { 85 + background: transparent; 86 + border-bottom: 1px solid {$thinblueborder}; 87 + } 88 + 89 + .phui-document-view.phui-document-view-pro .phui-header-shell { 90 + margin: 0; 91 + padding: 16px 0 32px; 92 + } 93 + 94 + .device-phone .phui-document-view.phui-document-view-pro .phui-header-shell { 95 + margin: 8px 0 0 0; 96 + } 97 + 98 + .phui-document-view.phui-document-view-pro .phui-header-tall 99 + .phui-header-header { 100 + font-size: 24px; 101 + line-height: 30px; 102 + color: #000; 103 + } 104 + 105 + .device-phone .phui-document-view-pro .phui-header-subheader { 106 + display: block; 107 + padding: 8px 0 0 0; 108 + }
+2 -3
webroot/rsrc/css/phui/phui-document.css
··· 86 86 .phui-header-shell.phui-header-no-backgound 87 87 .phui-header-view { 88 88 padding: 8px 0 4px; 89 - font-size: {$biggestfontsize}; 90 89 } 91 90 92 91 .phui-document-content .phui-property-list-container { ··· 181 180 182 181 .phui-document-view .PhabricatorMonospaced, 183 182 .phui-document-view .phabricator-remarkup .remarkup-code-block .remarkup-code { 184 - font: 11px/14px "Menlo", "Consolas", "Monaco", monospace; 183 + font: 11px/16px "Menlo", "Consolas", "Monaco", monospace; 185 184 } 186 185 187 186 .platform-windows .phui-document-view .PhabricatorMonospaced, 188 187 .platform-windows .phui-document-view .phabricator-remarkup .remarkup-code-block 189 188 .remarkup-code { 190 - font: 12px/14px "Menlo", "Consolas", "Monaco", monospace; 189 + font: 12px/16px "Menlo", "Consolas", "Monaco", monospace; 191 190 }
+1 -2
webroot/rsrc/css/phui/phui-fontkit.css
··· 10 10 11 11 .diviner-document-section .phui-header-header { 12 12 font-family: 'Roboto Slab', {$fontfamily}; 13 - font-size: 20px; 14 13 color: #000; 15 14 } 16 15 ··· 30 29 .phui-document-view .phabricator-remarkup h2.remarkup-header { 31 30 padding: 0 24px 8px 0; 32 31 border-bottom: 1px solid {$thinblueborder}; 33 - margin: 24px 0 16px; 32 + margin: 32px 0 16px; 34 33 }