recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename concrete Harbormaster step implementations

Summary: Ref T1049. For consistency, rename these to "Harbormaster...".

Test Plan: Ran migration, ran builds, everything still works fine.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D8602

epriestley cec8d107 281f06e2

+53 -18
+35
resources/sql/autopatches/20140323.harbor.1.renames.php
··· 1 + <?php 2 + 3 + $names = array( 4 + 'CommandBuildStepImplementation', 5 + 'LeaseHostBuildStepImplementation', 6 + 'PublishFragmentBuildStepImplementation', 7 + 'SleepBuildStepImplementation', 8 + 'UploadArtifactBuildStepImplementation', 9 + 'WaitForPreviousBuildStepImplementation', 10 + ); 11 + 12 + $tables = array( 13 + id(new HarbormasterBuildStep())->getTableName(), 14 + id(new HarbormasterBuildTarget())->getTableName(), 15 + ); 16 + 17 + echo "Renaming Harbormaster classes...\n"; 18 + 19 + $conn_w = id(new HarbormasterBuildStep())->establishConnection('w'); 20 + foreach ($names as $name) { 21 + $old = $name; 22 + $new = 'Harbormaster'.$name; 23 + 24 + echo "Renaming {$old} -> {$new}...\n"; 25 + foreach ($tables as $table) { 26 + queryfx( 27 + $conn_w, 28 + 'UPDATE %T SET className = %s WHERE className = %s', 29 + $table, 30 + $new, 31 + $old); 32 + } 33 + } 34 + 35 + echo "Done.\n";
+12 -12
src/__phutil_library_map__.php
··· 111 111 'CelerityResourcesOnDisk' => 'infrastructure/celerity/resources/CelerityResourcesOnDisk.php', 112 112 'CeleritySpriteGenerator' => 'infrastructure/celerity/CeleritySpriteGenerator.php', 113 113 'CelerityStaticResourceResponse' => 'infrastructure/celerity/CelerityStaticResourceResponse.php', 114 - 'CommandBuildStepImplementation' => 'applications/harbormaster/step/CommandBuildStepImplementation.php', 115 114 'ConduitAPIMethod' => 'applications/conduit/method/ConduitAPIMethod.php', 116 115 'ConduitAPIRequest' => 'applications/conduit/protocol/ConduitAPIRequest.php', 117 116 'ConduitAPIResponse' => 'applications/conduit/protocol/ConduitAPIResponse.php', ··· 730 729 'HarbormasterBuildableSearchEngine' => 'applications/harbormaster/query/HarbormasterBuildableSearchEngine.php', 731 730 'HarbormasterBuildableViewController' => 'applications/harbormaster/controller/HarbormasterBuildableViewController.php', 732 731 'HarbormasterCapabilityManagePlans' => 'applications/harbormaster/capability/HarbormasterCapabilityManagePlans.php', 732 + 'HarbormasterCommandBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php', 733 733 'HarbormasterController' => 'applications/harbormaster/controller/HarbormasterController.php', 734 734 'HarbormasterDAO' => 'applications/harbormaster/storage/HarbormasterDAO.php', 735 735 'HarbormasterHTTPRequestBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php', 736 + 'HarbormasterLeaseHostBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php', 736 737 'HarbormasterManagementBuildWorkflow' => 'applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php', 737 738 'HarbormasterManagementWorkflow' => 'applications/harbormaster/management/HarbormasterManagementWorkflow.php', 738 739 'HarbormasterObject' => 'applications/harbormaster/storage/HarbormasterObject.php', ··· 750 751 'HarbormasterPlanOrderController' => 'applications/harbormaster/controller/HarbormasterPlanOrderController.php', 751 752 'HarbormasterPlanRunController' => 'applications/harbormaster/controller/HarbormasterPlanRunController.php', 752 753 'HarbormasterPlanViewController' => 'applications/harbormaster/controller/HarbormasterPlanViewController.php', 754 + 'HarbormasterPublishFragmentBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterPublishFragmentBuildStepImplementation.php', 753 755 'HarbormasterRemarkupRule' => 'applications/harbormaster/remarkup/HarbormasterRemarkupRule.php', 754 756 'HarbormasterScratchTable' => 'applications/harbormaster/storage/HarbormasterScratchTable.php', 757 + 'HarbormasterSleepBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterSleepBuildStepImplementation.php', 755 758 'HarbormasterStepAddController' => 'applications/harbormaster/controller/HarbormasterStepAddController.php', 756 759 'HarbormasterStepDeleteController' => 'applications/harbormaster/controller/HarbormasterStepDeleteController.php', 757 760 'HarbormasterStepEditController' => 'applications/harbormaster/controller/HarbormasterStepEditController.php', 758 761 'HarbormasterTargetWorker' => 'applications/harbormaster/worker/HarbormasterTargetWorker.php', 759 762 'HarbormasterThrowExceptionBuildStep' => 'applications/harbormaster/step/HarbormasterThrowExceptionBuildStep.php', 760 763 'HarbormasterUIEventListener' => 'applications/harbormaster/event/HarbormasterUIEventListener.php', 764 + 'HarbormasterUploadArtifactBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php', 765 + 'HarbormasterWaitForPreviousBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php', 761 766 'HarbormasterWorker' => 'applications/harbormaster/worker/HarbormasterWorker.php', 762 767 'HeraldAction' => 'applications/herald/storage/HeraldAction.php', 763 768 'HeraldAdapter' => 'applications/herald/adapter/HeraldAdapter.php', ··· 815 820 'JavelinUIExample' => 'applications/uiexample/examples/JavelinUIExample.php', 816 821 'JavelinViewExample' => 'applications/uiexample/examples/JavelinViewExample.php', 817 822 'JavelinViewExampleServerView' => 'applications/uiexample/examples/JavelinViewExampleServerView.php', 818 - 'LeaseHostBuildStepImplementation' => 'applications/harbormaster/step/LeaseHostBuildStepImplementation.php', 819 823 'LegalpadCapabilityDefaultEdit' => 'applications/legalpad/capability/LegalpadCapabilityDefaultEdit.php', 820 824 'LegalpadCapabilityDefaultView' => 'applications/legalpad/capability/LegalpadCapabilityDefaultView.php', 821 825 'LegalpadConstants' => 'applications/legalpad/constants/LegalpadConstants.php', ··· 2457 2461 'ProjectBoardTaskCard' => 'applications/project/view/ProjectBoardTaskCard.php', 2458 2462 'ProjectCapabilityCreateProjects' => 'applications/project/capability/ProjectCapabilityCreateProjects.php', 2459 2463 'ProjectRemarkupRule' => 'applications/project/remarkup/ProjectRemarkupRule.php', 2460 - 'PublishFragmentBuildStepImplementation' => 'applications/harbormaster/step/PublishFragmentBuildStepImplementation.php', 2461 2464 'QueryFormattingTestCase' => 'infrastructure/storage/__tests__/QueryFormattingTestCase.php', 2462 2465 'ReleephAuthorFieldSpecification' => 'applications/releeph/field/specification/ReleephAuthorFieldSpecification.php', 2463 2466 'ReleephBranch' => 'applications/releeph/storage/ReleephBranch.php', ··· 2536 2539 'ReleephSummaryFieldSpecification' => 'applications/releeph/field/specification/ReleephSummaryFieldSpecification.php', 2537 2540 'ReleephUserView' => 'applications/releeph/view/user/ReleephUserView.php', 2538 2541 'ShellLogView' => 'applications/harbormaster/view/ShellLogView.php', 2539 - 'SleepBuildStepImplementation' => 'applications/harbormaster/step/SleepBuildStepImplementation.php', 2540 2542 'SlowvoteEmbedView' => 'applications/slowvote/view/SlowvoteEmbedView.php', 2541 2543 'SlowvoteRemarkupRule' => 'applications/slowvote/remarkup/SlowvoteRemarkupRule.php', 2542 2544 'SubscriptionListDialogBuilder' => 'applications/subscriptions/view/SubscriptionListDialogBuilder.php', 2543 2545 'SubscriptionListStringBuilder' => 'applications/subscriptions/view/SubscriptionListStringBuilder.php', 2544 - 'UploadArtifactBuildStepImplementation' => 'applications/harbormaster/step/UploadArtifactBuildStepImplementation.php', 2545 - 'WaitForPreviousBuildStepImplementation' => 'applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php', 2546 2546 ), 2547 2547 'function' => 2548 2548 array( ··· 2663 2663 'CelerityResourceGraph' => 'AbstractDirectedGraph', 2664 2664 'CelerityResourceTransformerTestCase' => 'PhabricatorTestCase', 2665 2665 'CelerityResourcesOnDisk' => 'CelerityPhysicalResources', 2666 - 'CommandBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 2667 2666 'ConduitAPIMethod' => 2668 2667 array( 2669 2668 0 => 'Phobject', ··· 3351 3350 'HarbormasterBuildableSearchEngine' => 'PhabricatorApplicationSearchEngine', 3352 3351 'HarbormasterBuildableViewController' => 'HarbormasterController', 3353 3352 'HarbormasterCapabilityManagePlans' => 'PhabricatorPolicyCapability', 3353 + 'HarbormasterCommandBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3354 3354 'HarbormasterController' => 'PhabricatorController', 3355 3355 'HarbormasterDAO' => 'PhabricatorLiskDAO', 3356 3356 'HarbormasterHTTPRequestBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3357 + 'HarbormasterLeaseHostBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3357 3358 'HarbormasterManagementBuildWorkflow' => 'HarbormasterManagementWorkflow', 3358 3359 'HarbormasterManagementWorkflow' => 'PhabricatorManagementWorkflow', 3359 3360 'HarbormasterObject' => 'HarbormasterDAO', ··· 3375 3376 'HarbormasterPlanOrderController' => 'HarbormasterController', 3376 3377 'HarbormasterPlanRunController' => 'HarbormasterController', 3377 3378 'HarbormasterPlanViewController' => 'HarbormasterPlanController', 3379 + 'HarbormasterPublishFragmentBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3378 3380 'HarbormasterRemarkupRule' => 'PhabricatorRemarkupRuleObject', 3379 3381 'HarbormasterScratchTable' => 'HarbormasterDAO', 3382 + 'HarbormasterSleepBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3380 3383 'HarbormasterStepAddController' => 'HarbormasterController', 3381 3384 'HarbormasterStepDeleteController' => 'HarbormasterController', 3382 3385 'HarbormasterStepEditController' => 'HarbormasterController', 3383 3386 'HarbormasterTargetWorker' => 'HarbormasterWorker', 3384 3387 'HarbormasterThrowExceptionBuildStep' => 'HarbormasterBuildStepImplementation', 3385 3388 'HarbormasterUIEventListener' => 'PhabricatorEventListener', 3389 + 'HarbormasterUploadArtifactBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3390 + 'HarbormasterWaitForPreviousBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3386 3391 'HarbormasterWorker' => 'PhabricatorWorker', 3387 3392 'HeraldAction' => 'HeraldDAO', 3388 3393 'HeraldApplyTranscript' => 'HeraldDAO', ··· 3448 3453 'JavelinUIExample' => 'PhabricatorUIExample', 3449 3454 'JavelinViewExample' => 'PhabricatorUIExample', 3450 3455 'JavelinViewExampleServerView' => 'AphrontView', 3451 - 'LeaseHostBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3452 3456 'LegalpadCapabilityDefaultEdit' => 'PhabricatorPolicyCapability', 3453 3457 'LegalpadCapabilityDefaultView' => 'PhabricatorPolicyCapability', 3454 3458 'LegalpadController' => 'PhabricatorController', ··· 5398 5402 'PonderVoteSaveController' => 'PonderController', 5399 5403 'ProjectCapabilityCreateProjects' => 'PhabricatorPolicyCapability', 5400 5404 'ProjectRemarkupRule' => 'PhabricatorRemarkupRuleObject', 5401 - 'PublishFragmentBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5402 5405 'QueryFormattingTestCase' => 'PhabricatorTestCase', 5403 5406 'ReleephAuthorFieldSpecification' => 'ReleephFieldSpecification', 5404 5407 'ReleephBranch' => ··· 5502 5505 'ReleephSummaryFieldSpecification' => 'ReleephFieldSpecification', 5503 5506 'ReleephUserView' => 'AphrontView', 5504 5507 'ShellLogView' => 'AphrontView', 5505 - 'SleepBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5506 5508 'SlowvoteEmbedView' => 'AphrontView', 5507 5509 'SlowvoteRemarkupRule' => 'PhabricatorRemarkupRuleObject', 5508 - 'UploadArtifactBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5509 - 'WaitForPreviousBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5510 5510 ), 5511 5511 ));
+1 -1
src/applications/harbormaster/step/CommandBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class CommandBuildStepImplementation 3 + final class HarbormasterCommandBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {
+1 -1
src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class LeaseHostBuildStepImplementation 3 + final class HarbormasterLeaseHostBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {
+1 -1
src/applications/harbormaster/step/PublishFragmentBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterPublishFragmentBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class PublishFragmentBuildStepImplementation 3 + final class HarbormasterPublishFragmentBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {
+1 -1
src/applications/harbormaster/step/SleepBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterSleepBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class SleepBuildStepImplementation 3 + final class HarbormasterSleepBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {
+1 -1
src/applications/harbormaster/step/UploadArtifactBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class UploadArtifactBuildStepImplementation 3 + final class HarbormasterUploadArtifactBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {
+1 -1
src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php
··· 1 1 <?php 2 2 3 - final class WaitForPreviousBuildStepImplementation 3 + final class HarbormasterWaitForPreviousBuildStepImplementation 4 4 extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() {