recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show 404 on Project Reports page when Facts not installed

Summary:
Do not render empty canvases.

Closes T16265

Test Plan:
* Uninstall http://phorge.localhost/applications/view/PhabricatorFactApplication/
* Go to http://phorge.localhost/project/reports/3/, now get a 404 instead of empty canvases
* Go to http://phorge.localhost/maniphest/report/project/, see no "Burnup Rate" item in sidebar anymore (unrelated to this very patch)
* Click "View Chart" button on http://phorge.localhost/project/reports/3/, still get a 404 (unrelated to this very patch)

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16265

Differential Revision: https://we.phorge.it/D26355

Andre Klapper dcd831d8 eb3d69cc

+5
+5
src/applications/project/controller/PhabricatorProjectReportsController.php
··· 10 10 public function handleRequest(AphrontRequest $request) { 11 11 $viewer = $request->getViewer(); 12 12 13 + $class = PhabricatorFactApplication::class; 14 + if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) { 15 + return new Aphront404Response(); 16 + } 17 + 13 18 $response = $this->loadProject(); 14 19 if ($response) { 15 20 return $response;