@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a transaction has no quote ref, render "@user wrote:" properly
Summary:
Fixes T12576. In Javascript, `data.ref` is null, which is getting turned into `/quote/?ref=null`.
The code already handles this case, just not with `ref=null` happening in JS:
https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php;b54adc6161c205e146fabb801ca53a44d94da444$47-52
Test Plan:
{F4913862}
- Also quoted a normal comment on a normal object in a normal way.
Reviewers: amckinley, chad
Reviewed By: chad
Maniphest Tasks: T12576
Differential Revision: https://secure.phabricator.com/D17720
+14
-12
+11
-11
resources/celerity/map.php
+11
-11
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => 'a34d59bd',
11
11
'conpherence.pkg.js' => '5f86c17d',
12
12
'core.pkg.css' => '959330a2',
13
-
'core.pkg.js' => '4a83713e',
13
+
'core.pkg.js' => 'e129dcd4',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '90b30783',
16
16
'differential.pkg.js' => 'ddfeb49b',
···
446
446
'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96',
447
447
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '94c65b72',
448
448
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => 'b23b49e6',
449
-
'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
449
+
'rsrc/js/application/transactions/behavior-transaction-list.js' => '1f6794f6',
450
450
'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
451
451
'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
452
452
'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
···
672
672
'javelin-behavior-phabricator-show-older-transactions' => '94c65b72',
673
673
'javelin-behavior-phabricator-tooltips' => 'c420b0b9',
674
674
'javelin-behavior-phabricator-transaction-comment-form' => 'b23b49e6',
675
-
'javelin-behavior-phabricator-transaction-list' => '13c739ea',
675
+
'javelin-behavior-phabricator-transaction-list' => '1f6794f6',
676
676
'javelin-behavior-phabricator-watch-anchor' => '9f36c42d',
677
677
'javelin-behavior-pholio-mock-edit' => 'bee502c8',
678
678
'javelin-behavior-pholio-mock-view' => 'fbe497e7',
···
1016
1016
'javelin-dom',
1017
1017
'javelin-typeahead-normalizer',
1018
1018
),
1019
-
'13c739ea' => array(
1020
-
'javelin-behavior',
1021
-
'javelin-stratcom',
1022
-
'javelin-workflow',
1023
-
'javelin-dom',
1024
-
'javelin-uri',
1025
-
'phabricator-textareautils',
1026
-
),
1027
1019
'1499a8cb' => array(
1028
1020
'javelin-behavior',
1029
1021
'javelin-stratcom',
···
1079
1071
'javelin-mask',
1080
1072
'javelin-uri',
1081
1073
'javelin-routable',
1074
+
),
1075
+
'1f6794f6' => array(
1076
+
'javelin-behavior',
1077
+
'javelin-stratcom',
1078
+
'javelin-workflow',
1079
+
'javelin-dom',
1080
+
'javelin-uri',
1081
+
'phabricator-textareautils',
1082
1082
),
1083
1083
'1fe2510c' => array(
1084
1084
'javelin-install',
+3
-1
webroot/rsrc/js/application/transactions/behavior-transaction-list.js
+3
-1
webroot/rsrc/js/application/transactions/behavior-transaction-list.js