@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up some PhamePostEditor archive cases
Summary: Forgot to save this file locally. Adds isArchived to same hidden features as isDraft
Test Plan: test mail on archived posts
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16106
+3
-3
+3
-3
src/applications/phame/editor/PhamePostEditor.php
+3
-3
src/applications/phame/editor/PhamePostEditor.php
···
171
171
protected function shouldSendMail(
172
172
PhabricatorLiskDAO $object,
173
173
array $xactions) {
174
-
if ($object->isDraft()) {
174
+
if ($object->isDraft() || ($object->isArchived())) {
175
175
return false;
176
176
}
177
177
return true;
···
180
180
protected function shouldPublishFeedStory(
181
181
PhabricatorLiskDAO $object,
182
182
array $xactions) {
183
-
if ($object->isDraft()) {
183
+
if ($object->isDraft() || $object->isArchived()) {
184
184
return false;
185
185
}
186
186
return true;
···
231
231
foreach ($xactions as $xaction) {
232
232
switch ($xaction->getTransactionType()) {
233
233
case PhamePostTransaction::TYPE_VISIBILITY:
234
-
if (!$object->isDraft()) {
234
+
if (!$object->isDraft() && !$object->isArchived()) {
235
235
$body->addRemarkupSection(null, $object->getBody());
236
236
}
237
237
break;