recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=diffusionCallsignHistory, ref.master=9b99123ff931, ref.diffusionCallsignHistory=d5fb6702a49a)
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/controller/DiffusionCommitController.php:31]
```

Closes T15466

Test Plan: After applying this change, going to an existing commit URL like `/diffusion/XYZ/commit/999a2c7d1ff8` shows the exception covered by T15464 instead, as expected.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15466

Differential Revision: https://we.phorge.it/D25290

Andre Klapper efbb809d 32b2d387

+3 -2
+3 -2
src/applications/diffusion/controller/DiffusionCommitController.php
··· 27 27 28 28 // If this page is being accessed via "/source/xyz/commit/...", redirect 29 29 // to the canonical URI. 30 - $has_callsign = strlen($request->getURIData('repositoryCallsign')); 31 - $has_id = strlen($request->getURIData('repositoryID')); 30 + $has_callsign = 31 + phutil_nonempty_string($request->getURIData('repositoryCallsign')); 32 + $has_id = phutil_nonempty_string($request->getURIData('repositoryID')); 32 33 if (!$has_callsign && !$has_id) { 33 34 $canonical_uri = $repository->getCommitURI($commit_identifier); 34 35 return id(new AphrontRedirectResponse())