Remove strikethrough, comments, and footnotes from `textContent` #170

Merged

stevedylan.dev 5mo ago

targeting main from jack.is/sequoia:remove-additional-markdown

Merged opened by and assigned to

stevedylan.dev 5mo ago targeting main from jack.is/sequoia:remove-additional-markdown

Fixes #36.

Commits 0

Could not load commits.

Comments

v0 5mo ago

heaths.dev 5mo ago

packages/cli/src/lib/markdown.ts:391 Some markdown flavors I've seen use a single tilde. Should we account for a balanced pair? Catching 1 or more and then a backref to the capture would also handle any number of tildes as long as they are balanced.

jack.is 5mo ago

Yeah, good call.

heaths.dev 5mo ago

packages/cli/src/lib/markdown.ts:392

@jack.is I made a change while adding some tests. Take a look at https://tangled.org/stevedylan.dev/sequoia/pulls/new. Also, your regexes remove the footnote itself, but not the reference. Was removing the reference intended as well?

jack.is 5mo ago

Could have sworn it removed the references in the copy :v

I'll make a fast follow to fix this.

Versions