Monorepo for Tangled tangled.org
812
fork

Configure Feed

Select the types of activity you want to include in your feed.

PR blocked on merge conflicts that don't exist #321

open opened by str4d.xyz

I opened my first Tangled PR: https://tangled.org/str4d.xyz/atproto-devtool/pulls/1/round/0

The PR's branch is directly based on main, and I confirmed locally that it can be merged cleanly. However, the Tangled UI has disabled the merge button and shows a merge conflicts detected warning. But clicking "expand" shows nothing. The HTML node is rendered as:

<details class="group/conflict">
      <summary class="flex items-center justify-between cursor-pointer list-none">
        <div class="flex items-center gap-2 ">
          <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="text-red-600 dark:text-red-500 w-4 h-4">
  <path d="m21.73 18-8-14a2 2 0 0 0-3.48 0l-8 14A2 2 0 0 0 4 21h16a2 2 0 0 0 1.73-3"></path>
  <path d="M12 9v4"></path>
  <path d="M12 17h.01"></path>
</svg>

          <span class="font-medium">merge conflicts detected</span>
          <div class="text-sm text-gray-500 dark:text-gray-400">
            <span class="group-open/conflict:hidden inline">expand</span>
            <span class="hidden group-open/conflict:inline">collapse</span>
          </div>
        </div>
      </summary>
      
    </details>

thanks for the report! have identified the bug, will fix this up soon and release a new revision of the knotserver.

I went ahead and merged my branch into main locally, but the PR has remained open. IDK if that is related to this issue (the PR not being mergeable) or if Tangled currently lacks "external merge detection".

the latter is true: tangled does not detect merges that happen locally to mark PRs as merged yet.

Another instance of the bug I think (in case it helps) - this time it does show a couple of conflicting files in the UI, but they do not actually conflict (as the PR includes a merge from main that fixed all conflicts): https://tangled.org/str4d.xyz/atproto-devtool/pulls/4/round/2

sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:bvdrfwiamgi5leqs63q2duro/sh.tangled.repo.issue/3mjl3fsz2gn22