Monorepo for Tangled tangled.org

Can't associate @users.noreply.github.com email to account, fails `net.LookupMX(domain)` #342

Closed boltless.me
Closed opened by boltless.me

yeah, only emails with MX records can be associated with your account.

@prospector.modrinth.com That's totally understandable, but it is hard to implement with Tangled's architecture. We need to check if same user does own that email.

GitHub's noreply address works because they are centralized platform. They associated all those emails to users. They can know which the noreply email is associated to which user without performing MX verification.

But in our case, we can't do that. We need to check if the user actually own that email so we can prevent a bad actor from falsely claiming ownership of that email address. Actually if you use non-verified email from github other than their noreply addresses, you can find that commit is also rendered as unverified.

One workaround we've made is to set your DID in commit email:

committer boltless <did:plc:xasnlahkri4ewmbuzly2rlc5> 1776078334 -0400

But this is not ideal because DID is clearly not an email.

Another possible option is to associate our own users.noreply.tangled.org emails. But then third-party appviews should blindly trust tangled.org so this is also not perfect.

Yeah each appviews should perform email verification individually anyways, so in that sense we can just use OAuth login to verify gh noreply email address.

Though I think currently it has pretty low priority. It isn't supported from any other forges afaik.

duplicate of #133 but I'll leave this open as #133 isn't searchable for some reason and this issue describes the problem in more detail.

don't think we want to relax this condition. so I'll be closing this issue!

Sign up or Sign in to add to the discussion.