Monorepo for Tangled tangled.org
758
fork

Configure Feed

Select the types of activity you want to include in your feed.

suggestion: {repo}/goodfirstissues as shorthand URL for open issues with good-first-issue tag #39

open opened by bhmt.dev

I'd also be interested in contributing this myself. It's one of a handful of things I've noticed while attempting to find good, introductory bugs. But I'm still familiarizing myself with your codebase. (And I'm entirely unfamiliar with Go.)

what if we had something easier, like /contribute? cc @anirudh.fi @oyster.cafe and @boltless.me for some thoughts!

brilliant idea though, for the implementation, you would just have the appview/repo/router.go have a new handler that just redirects to {repo}/issues?q=... with the right query param for the label filter.

More or less what I thought on poking around a bit. The one snag that sticks out to me about the naming is that it could then create (more) confusion in having contribute in one place and goodfirstissues elsewhere (itself referencing good-first-issues)

New question: are redirects (or, generally, getting the results of some hard-coded URL) something that Chi router can do out of the box, or do I need to write a custom handler for that?

(Looking at this codebase I'm also a little unsure just how such a thing would need to be scoped, but that's on a pretty shallow read of a language I don't really know.)

On second thought why not route both names (at both the sitewide and repo level) to one place (each)?

On the redirect piece, I'm going to need to do small to moderate research dives on how Go handles redirects and how to get this dev environment up and running (which I was less concerned about for small typos), but will come back to this.

do have a look at the hacking section on docs.tangled.org! should be super easy to get setup.

good idea. I'd like to keep /contribute for more crazy dashboard-like page. Would be super cool.

/goodfirstissues is bit too long and easy to miss imo. It's just redirection, so we can have many:

  • /goodfirstissues
  • /goodfirstissue
  • /gfi all redirect to same issues page with gfi filter.

I think using "contribute" in blog navigating to gfi is completely fine. Maybe we can be more precise in appview footer? That would need a larger footer so I'm not sure.

cc @eti.tf

lgtm! don't think this requires an elaborate design, direct code impl sounds ok to me

@boltless.me if they're being used for different things it could get confusing later, but yeah

My other after-the-fact thought was to have this and the general Tangled repo link say "code (read)" and "code (write)," but that's maybe just that I like how it sounds/reads more than it is that it's necessarily better...

sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 4
AT URI
at://did:plc:6wgqufzto25uhayoex2bbkqh/sh.tangled.repo.issue/3mkkufqbujt22