make default branch required for repositories #600

Closed

boltless.me 5mo ago

Closed opened by

boltless.me 5mo ago

Repositories can currently be created without a default branch, causing the repository index page to appear empty. Enforce a default branch for all repositories to ensure repository content is accessible and the index page functions correctly.

For Knot, this means it will fallback to some branch when no configured default branch is not found.

For XRPC lexicon, this means defaultBranch will be a required field in output schema.

For AppView/KnotMirror, no changes yet. Wait until most repos to have a default branch for backwards compatibility.

willdot.net 4mo ago

I went to take a look at this, and it appears that a default branch is set to what ever the config of the knot server is set to.

Using default here: https://tangled.org/tangled.org/core/blob/master/knotserver/xrpc/create_repo.go#L63 Config set using main as default: https://tangled.org/tangled.org/core/blob/master/knotserver/config/config.go#L14

🤔

boltless.me 4mo ago

Yes, that's current behavior and I'd like to change that since it's unpredictable and could end up in broken state.

Say you create an empty repo (default branch set to main as default knot settings) and push tangled.org/core to it (using master). Now the repo has no default branch.

willdot.net 4mo ago

Ohh right I see what you mean now.

That clears things up, thanks 😄

boltless.me 1w ago

default branch is owned by required on lexicon. org.tangled.git.refs requires it, so every repository has a default branch. It might pointing to non-existing ref though.