Monorepo for Tangled tangled.org

rename `repo.Did` to `repo.Owner` #627

Closed oppi.li
Closed opened by oppi.li
assigned to boltless.me

repo.Did should be a DID of repository itself. Git repos are not tied to their current owner, so using .Did field for owner DID is not correct.

Same goes to repo.Rkey. Git repos are not a record, they are standalone identity and the source of truth is git repository DID, not record in someone's PDS.

old new
repo.RepoDid repo.Did
repo.Did repo.Owner
repo.Rkey repo.Slug or repo.Name

For xrpc method or record definition,

When we reference a git repository (e.g. sh.tangled.feed.star) -> name the field as repo with type string, DID format.

When we represent a git repository (e.g. sh.tangled.sync.listRepos) -> name the field as did since the object itself is already a "repo". It should be .repo.did instead of .repo.repo.

Makes sense.

outdated issue, closing!

Sign up or Sign in to add to the discussion.