Monorepo for Tangled tangled.org
859
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview: don't trust oauth.ClientSessionData #236

open opened by boltless.me targeting master from sl/uvpzuszrulvq

oauth.ClientSessionData.HostURL is not validated after first session creation. If user switches the PDS while logged in, .HostURL will still point to old PDS, showing account management options for tngl.sh users. This can confuse users to accidentally put account in odd state (activated in both PDSes)

Instead, always resolve Handles and PDS hosts on-demand. Technically HostURL is used on creating authorized atpclient, but that's ok because request to old PDS will reject the request.

Ideally we should revoke user sessions on #account event, indigo currently doesn't support DID based revoking.

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mhivzoc7en22
Diff #0

No differences found between the selected revisions.

History

1 round 0 comments
sign up or login to add to the discussion
boltless.me submitted #0
patch application failed: error: No valid patches in input (allow with "--allow-empty")
expand 0 comments